Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Filter #1419

Merged
merged 36 commits into from
Jul 22, 2024
Merged

Particle Filter #1419

merged 36 commits into from
Jul 22, 2024

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Jun 19, 2024

  • Mono-threaded version
  • Multi-threaded version
  • Example
  • Unit tests
  • Make the class template to use other classes than vpColVector as measurements
  • Tutorial: code
  • Tutorial: documentation

@rolalaro rolalaro marked this pull request as draft June 19, 2024 11:57
@rolalaro rolalaro changed the title DRAFT: Particle Filter Particle Filter Jun 19, 2024
…weights should have been w[i]_{k} = w[i]_{k-1} * likelihood
@rolalaro
Copy link
Author

@fspindle Should I make the vpParticleFilter class a template class to allow
having other types than vpColVector for the measurements ?
It would affect the signature of the vpLikelihoodFunction but would have no other
effects on the class.
It would permit to use e.g. a pcl::PointCloud for the measurement instead of having to convert it
into a vpColVector. However, as far as I know, template classes are not allowed in Python, so the
Python wrapping would be limited to vpColVector.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 75.18797% with 99 lines in your changes missing coverage. Please review.

Project coverage is 45.42%. Comparing base (2394054) to head (70e8e7e).
Report is 8 commits behind head on master.

Files Patch % Lines
example/particle-filter/pf-nonlinear-example.cpp 69.26% 79 Missing ⚠️
modules/core/include/visp3/core/vpParticleFilter.h 95.31% 6 Missing ⚠️
modules/gui/include/visp3/gui/vpDisplayFactory.h 0.00% 6 Missing ⚠️
tutorial/image/tutorial-draw-circle.cpp 0.00% 2 Missing ⚠️
tutorial/grabber/tutorial-grabber-1394-writer.cpp 0.00% 1 Missing ⚠️
...utorial/grabber/tutorial-grabber-v4l2-threaded.cpp 0.00% 1 Missing ⚠️
tutorial/grabber/tutorial-video-reader.cpp 0.00% 1 Missing ⚠️
tutorial/grabber/tutorial-video-recorder.cpp 0.00% 1 Missing ⚠️
...l/robot/mbot/raspberry/visp/mbot-apriltag-ibvs.cpp 0.00% 1 Missing ⚠️
...l/robot/mbot/raspberry/visp/mbot-apriltag-pbvs.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
+ Coverage   45.30%   45.42%   +0.12%     
==========================================
  Files        1108     1110       +2     
  Lines      110137   110523     +386     
  Branches    18873    18922      +49     
==========================================
+ Hits        49895    50203     +308     
- Misses      60242    60320      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rolalaro rolalaro marked this pull request as ready for review July 8, 2024 05:51
@fspindle fspindle merged commit 7a68e46 into lagadic:master Jul 22, 2024
76 of 77 checks passed
@rolalaro rolalaro deleted the feat_particle_filter branch July 24, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants