Add Debug/ReleaseSafe matrix axis to extended CI#330
Conversation
Test each target configuration in both Debug and ReleaseSafe modes. Change check.sh --release from ReleaseFast to ReleaseSafe.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe PR introduces PR body-based extended test triggering via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/test.yml:
- Line 13: The expression using the `||` operator on string outputs
(steps.filter.outputs.extended || steps.keyword.outputs.extended) is wrong
because dorny/paths-filter returns the string 'false', which is truthy; change
the condition to compare each output explicitly to the string 'true' (e.g.,
check steps.filter.outputs.extended == 'true' or steps.keyword.outputs.extended
== 'true') so the logical OR operates on boolean results and the `[ci:extended]`
keyword path is evaluated correctly.
Summary
release: [false, true]matrix axis to the extended CI job, testing each target in both Debug and ReleaseSafe modescheck.sh --releasefrom ReleaseFast to ReleaseSafe