Skip to content

Comments

Add Debug/ReleaseSafe matrix axis to extended CI#330

Merged
lalinsky merged 3 commits intomainfrom
ci-release-safe-matrix
Feb 20, 2026
Merged

Add Debug/ReleaseSafe matrix axis to extended CI#330
lalinsky merged 3 commits intomainfrom
ci-release-safe-matrix

Conversation

@lalinsky
Copy link
Owner

Summary

  • Add release: [false, true] matrix axis to the extended CI job, testing each target in both Debug and ReleaseSafe modes
  • Change check.sh --release from ReleaseFast to ReleaseSafe

Test each target configuration in both Debug and ReleaseSafe modes.
Change check.sh --release from ReleaseFast to ReleaseSafe.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

Warning

Rate limit exceeded

@lalinsky has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The PR introduces PR body-based extended test triggering via [ci:extended] keyword detection, expands the extended job matrix with a release dimension to exercise both debug and release builds, and adjusts the build script to use ReleaseSafe optimization profile instead of ReleaseFast.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/test.yml
Adds step to detect [ci:extended] in PR body, propagates extended flag via GITHUB_OUTPUT, expands matrix with release dimension (false/true), and conditionally passes --release flag to check script based on matrix value.
Build Script
check.sh
Changes release build optimization profile from ReleaseFast to ReleaseSafe in logging and -Doptimize flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

A keyword in the PR body lights the way,
Extended tests now trigger without delay,
Release builds join the matrix game,
ReleaseSafe mode earns its name,
CI speaks what the developer didn't say. 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main changes: adding Debug/ReleaseSafe matrix axis to extended CI and switching from ReleaseFast to ReleaseSafe.
Description check ✅ Passed The description clearly relates to the changeset, covering both the matrix axis addition and the ReleaseFast to ReleaseSafe switch in check.sh.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci-release-safe-matrix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/test.yml:
- Line 13: The expression using the `||` operator on string outputs
(steps.filter.outputs.extended || steps.keyword.outputs.extended) is wrong
because dorny/paths-filter returns the string 'false', which is truthy; change
the condition to compare each output explicitly to the string 'true' (e.g.,
check steps.filter.outputs.extended == 'true' or steps.keyword.outputs.extended
== 'true') so the logical OR operates on boolean results and the `[ci:extended]`
keyword path is evaluated correctly.

@lalinsky lalinsky merged commit 62962c8 into main Feb 20, 2026
28 of 29 checks passed
@lalinsky lalinsky deleted the ci-release-safe-matrix branch February 20, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant