Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement notifications HUD #488

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

urFate
Copy link
Contributor

@urFate urFate commented Feb 5, 2023

Describe the pull
Implement nice looking notifications HUD. At the current state, nothing more than just draft to demonstrate what im wanna do and collect suggestions and improvements from community.

Describe how this pull is helpful
This element will help to focus the player's attention on important events in the game. For example, the use of the totem of immortality by the opponent or other important things. In the current implementation, sending chat notifications is very easy not to notice them with a huge flow of messages. It also adds more usefulness, beauty and convenience to our client.

Additional context
Notifications demo in current state.

2023-02-05.23-02-37.mp4

Copy link
Contributor

@scorbett123 scorbett123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty good, however I think there needs to be more configuration options, even an option to return back to just sending notifications in chat as some people would prefer that.

urFate and others added 2 commits February 7, 2023 00:18
I think a more opinionated set of rendering options works best for notifications, rather than letting users drag this around to random locations

I've also added a few configuration options to the rendering, updated the rendering to handle different scales, and removed most hardcoded numbers.
This lets us handle different window sizes better while still allowing some configuration by users within boundaries.
@rfresh2
Copy link
Member

rfresh2 commented Feb 10, 2023

I like the idea!

I've made some changes on my branch if you'd like to merge that into yours.

Things I've changed:

  • Migrated to a client module instead of a hud element
  • Improved support for various screen sizes by replacing most hardcoded values with math
  • Added various configuration options:
    • Mode: Sets if notifications are sent to chat, rendered, or both
    • Notification Height: Set the height of the notification box
    • Render Location: I think some opinionated locations for where notifications are rendered is best rather than letting users drag it around wherever.
    • H and W Padding: blank space vertically or horizontally around where notifications start
  • various other small changes like not forcing custom font

@kdh8219
Copy link
Contributor

kdh8219 commented Feb 11, 2023

#421

@urFate
Copy link
Contributor Author

urFate commented Feb 11, 2023

I like the idea!

I've made some changes on my branch if you'd like to merge that into yours.

Things I've changed:

  • Migrated to a client module instead of a hud element

  • Improved support for various screen sizes by replacing most hardcoded values with math

  • Added various configuration options:

    • Mode: Sets if notifications are sent to chat, rendered, or both
    • Notification Height: Set the height of the notification box
    • Render Location: I think some opinionated locations for where notifications are rendered is best rather than letting users drag it around wherever.
    • H and W Padding: blank space vertically or horizontally around where notifications start
  • various other small changes like not forcing custom font

Merged it with a bit of changes. Now I can continue work with animations.

@urFate
Copy link
Contributor Author

urFate commented Feb 12, 2023

Fade effects demo

2023-02-12.16-43-49.mp4

@kdh8219
Copy link
Contributor

kdh8219 commented Mar 20, 2023

I've made animation on my brach!

cuted_notification.mov

@urFate
Copy link
Contributor Author

urFate commented Mar 20, 2023

I've made animation on my brach!

Good work comrade! Merged it 👍

@kdh8219
Copy link
Contributor

kdh8219 commented Mar 21, 2023

Fix y moving animation here
so sorry....

@kdh8219
Copy link
Contributor

kdh8219 commented Jun 26, 2023

#144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants