Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ohadn/stwo exclusive programs folder #1939

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ohad-nir-starkware
Copy link
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Feb 10, 2025

stwo exclusive programs

Description

prepare rust.yml and MakeFile for the folder stwo_exclusive_programs which will contain programs that will be run but not yet proven.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

Copy link

github-actions bot commented Feb 10, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     31.824 s ±  0.042 s    [User: 31.105 s, System: 0.717 s]
  Range (min … max):   31.794 s … 31.854 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     32.298 s ±  0.486 s    [User: 31.553 s, System: 0.744 s]
  Range (min … max):   31.954 s … 32.642 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     17.699 s ±  0.060 s    [User: 31.136 s, System: 0.755 s]
  Range (min … max):   17.657 s … 17.742 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     17.749 s ±  0.019 s    [User: 31.156 s, System: 0.767 s]
  Range (min … max):   17.736 s … 17.763 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     12.281 s ±  0.894 s    [User: 44.699 s, System: 0.915 s]
  Range (min … max):   11.649 s … 12.914 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     12.181 s ±  0.646 s    [User: 44.397 s, System: 0.894 s]
  Range (min … max):   11.724 s … 12.638 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.09 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     12.094 s ±  0.240 s    [User: 44.504 s, System: 0.894 s]
  Range (min … max):   11.924 s … 12.264 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     12.404 s ±  0.283 s    [User: 44.068 s, System: 0.943 s]
  Range (min … max):   12.204 s … 12.604 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.03 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     12.198 s ±  0.209 s    [User: 44.569 s, System: 0.925 s]
  Range (min … max):   12.051 s … 12.346 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     12.102 s ±  0.104 s    [User: 44.592 s, System: 0.932 s]
  Range (min … max):   12.029 s … 12.176 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     12.188 s ±  0.006 s    [User: 44.607 s, System: 0.992 s]
  Range (min … max):   12.183 s … 12.192 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     11.825 s ±  0.138 s    [User: 44.668 s, System: 1.016 s]
  Range (min … max):   11.727 s … 11.922 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.03 ± 0.01 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Feb 10, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.528 ± 0.042 2.492 2.611 1.00
head big_factorial 2.555 ± 0.080 2.493 2.703 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.503 ± 0.076 2.435 2.685 1.02 ± 0.03
head big_fibonacci 2.450 ± 0.030 2.427 2.528 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.185 ± 0.140 9.101 9.568 1.00
head blake2s_integration_benchmark 9.411 ± 0.468 9.108 10.597 1.02 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.636 ± 0.040 2.605 2.729 1.00 ± 0.02
head compare_arrays_200000 2.623 ± 0.033 2.581 2.681 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.757 ± 0.016 1.737 1.787 1.02 ± 0.02
head dict_integration_benchmark 1.727 ± 0.028 1.690 1.775 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.461 ± 0.027 1.446 1.537 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 1.441 ± 0.010 1.432 1.460 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.395 ± 0.309 9.221 10.259 1.00 ± 0.05
head integration_builtins 9.372 ± 0.312 9.194 10.076 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.470 ± 0.053 9.382 9.540 1.00
head keccak_integration_benchmark 9.515 ± 0.062 9.437 9.647 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.658 ± 0.090 2.599 2.893 1.03 ± 0.04
head linear_search 2.572 ± 0.015 2.552 2.602 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.807 ± 0.052 1.779 1.950 1.03 ± 0.03
head math_cmp_and_pow_integration_benchmark 1.754 ± 0.013 1.732 1.777 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.768 ± 0.014 1.748 1.797 1.01 ± 0.04
head math_integration_benchmark 1.747 ± 0.061 1.701 1.886 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.482 ± 0.042 1.448 1.587 1.02 ± 0.03
head memory_integration_benchmark 1.446 ± 0.022 1.425 1.499 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.854 ± 0.017 1.831 1.894 1.02 ± 0.01
head operations_with_data_structures_benchmarks 1.811 ± 0.017 1.795 1.855 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 595.7 ± 7.3 588.1 613.9 1.00 ± 0.02
head pedersen 592.8 ± 6.7 587.6 610.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 716.4 ± 8.3 707.0 734.0 1.00
head poseidon_integration_benchmark 718.9 ± 11.1 691.1 729.3 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.082 ± 0.015 2.062 2.107 1.01 ± 0.01
head secp_integration_benchmark 2.071 ± 0.016 2.054 2.104 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 689.1 ± 2.9 685.9 695.4 1.00
head set_integration_benchmark 690.4 ± 11.6 680.2 715.2 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.163 ± 0.078 5.099 5.343 1.00 ± 0.03
head uint256_integration_benchmark 5.156 ± 0.127 5.053 5.453 1.00

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (974e621) to head (23b291c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1939   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         102      102           
  Lines       41238    41238           
=======================================
  Hits        39742    39742           
  Misses       1496     1496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/stwo_exclusive_programs_folder branch from e7382da to 4f53823 Compare February 11, 2025 09:29
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! @ohad-nir-starkware! I left you a small suggestion.

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/get_u32_range branch 2 times, most recently from 9c699c9 to 4598d76 Compare February 11, 2025 17:49
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/stwo_exclusive_programs_folder branch from 4f53823 to 51f7f4d Compare February 11, 2025 18:06
@JulianGCalderon JulianGCalderon added the pipelines This PR/issue is exclusively about improving our CI label Feb 11, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/stwo_exclusive_programs_folder branch from 51f7f4d to e4a3cb4 Compare February 11, 2025 18:29
Base automatically changed from ohadn/get_u32_range to main February 11, 2025 19:06
…which will contain programs that will be run but not yet proven
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/stwo_exclusive_programs_folder branch from 1019002 to 23b291c Compare February 11, 2025 19:28
Copy link
Collaborator Author

@ohad-nir-starkware ohad-nir-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @fmoletta, @igaray, @juanbono, @JulianGCalderon, @Oppen, @pefontana, and @YairVaknin-starkware)

CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@JulianGCalderon JulianGCalderon added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 1a135db Feb 11, 2025
93 checks passed
@JulianGCalderon JulianGCalderon deleted the ohadn/stwo_exclusive_programs_folder branch February 11, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants