Skip to content

Add extended_resource_counter, only with Blake for now #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MeidarSharkansky-starkware wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add extended_resource_counter, only with Blake for now #2322

MeidarSharkansky-starkware wants to merge 1 commit into from
+55 −0

Conversation

@MeidarSharkansky-starkware
Copy link
Collaborator

@MeidarSharkansky-starkware MeidarSharkansky-starkware commented Feb 9, 2026 •
edited
Loading

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     23.161 s ±  0.120 s    [User: 22.284 s, System: 0.875 s]
  Range (min … max):   23.076 s … 23.246 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     22.896 s ±  0.005 s    [User: 22.029 s, System: 0.863 s]
  Range (min … max):   22.892 s … 22.899 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     12.375 s ±  0.007 s    [User: 22.166 s, System: 0.892 s]
  Range (min … max):   12.370 s … 12.381 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     12.345 s ±  0.068 s    [User: 22.081 s, System: 0.915 s]
  Range (min … max):   12.297 s … 12.394 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.750 s ±  0.060 s    [User: 35.313 s, System: 1.080 s]
  Range (min … max):    9.707 s …  9.792 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):      9.765 s ±  0.204 s    [User: 35.830 s, System: 1.105 s]
  Range (min … max):    9.621 s …  9.910 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.00 ± 0.02 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.772 s ±  0.042 s    [User: 35.766 s, System: 1.127 s]
  Range (min … max):    9.743 s …  9.802 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.923 s ±  0.425 s    [User: 35.969 s, System: 1.130 s]
  Range (min … max):    9.622 s … 10.224 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.04 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.600 s ±  0.086 s    [User: 36.164 s, System: 1.165 s]
  Range (min … max):    9.539 s …  9.661 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.670 s ±  0.027 s    [User: 36.288 s, System: 1.160 s]
  Range (min … max):    9.651 s …  9.689 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.686 s ±  0.042 s    [User: 36.178 s, System: 1.237 s]
  Range (min … max):    9.656 s …  9.716 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.933 s ±  0.221 s    [User: 36.234 s, System: 1.203 s]
  Range (min … max):    9.777 s … 10.089 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.03 ± 0.02 times faster than hyper_threading_pr threads: 16

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.00%. Comparing base (677b1c7) to head (8e37dd3).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #2322    +/-   ##
========================================
  Coverage   95.99%   96.00%            
========================================
  Files         104      104            
  Lines       36918    37026   +108     
========================================
+ Hits        35440    35545   +105     
- Misses       1478     1481     +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.222 ± 0.018 2.208 2.271 1.12 ± 0.01
head big_factorial 1.984 ± 0.014 1.970 2.009 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.143 ± 0.004 2.138 2.150 1.12 ± 0.01
head big_fibonacci 1.921 ± 0.012 1.909 1.952 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.768 ± 0.144 7.687 8.120 1.12 ± 0.02
head blake2s_integration_benchmark 6.921 ± 0.029 6.891 6.988 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.292 ± 0.014 2.272 2.320 1.12 ± 0.01
head compare_arrays_200000 2.054 ± 0.008 2.045 2.074 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.482 ± 0.002 1.477 1.484 1.09 ± 0.00
head dict_integration_benchmark 1.354 ± 0.004 1.349 1.362 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.269 ± 0.017 1.262 1.318 1.10 ± 0.02
head field_arithmetic_get_square_benchmark 1.152 ± 0.003 1.148 1.157 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.843 ± 0.014 7.826 7.876 1.12 ± 0.00
head integration_builtins 7.026 ± 0.027 7.002 7.090 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.865 ± 0.012 7.842 7.885 1.11 ± 0.00
head keccak_integration_benchmark 7.064 ± 0.017 7.046 7.102 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.280 ± 0.042 2.258 2.398 1.11 ± 0.02
head linear_search 2.054 ± 0.014 2.033 2.083 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.580 ± 0.005 1.572 1.587 1.10 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.441 ± 0.005 1.436 1.450 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.531 ± 0.014 1.511 1.563 1.10 ± 0.01
head math_integration_benchmark 1.392 ± 0.009 1.381 1.410 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.283 ± 0.013 1.274 1.311 1.12 ± 0.01
head memory_integration_benchmark 1.148 ± 0.006 1.143 1.164 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.605 ± 0.004 1.599 1.613 1.09 ± 0.01
head operations_with_data_structures_benchmarks 1.475 ± 0.006 1.467 1.487 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 544.6 ± 1.1 543.3 547.0 1.06 ± 0.00
head pedersen 514.6 ± 1.2 512.9 516.8 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 628.4 ± 3.0 626.1 636.7 1.05 ± 0.01
head poseidon_integration_benchmark 598.5 ± 1.6 595.9 601.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.849 ± 0.006 1.840 1.860 1.07 ± 0.00
head secp_integration_benchmark 1.726 ± 0.005 1.721 1.738 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 684.8 ± 1.5 683.0 687.8 1.05 ± 0.00
head set_integration_benchmark 654.0 ± 1.8 651.3 657.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.388 ± 0.010 4.370 4.405 1.11 ± 0.01
head uint256_integration_benchmark 3.953 ± 0.027 3.935 4.026 1.00

gabrielbosio
gabrielbosio reviewed Feb 9, 2026
View reviewed changes
vm/src/vm/runners/cairo_runner.rs
Comment on lines +1652 to +1654
pub struct ExtendedExecutionResources {
pub extended_resource_counter: HashMap<ExtendedExecutionResourceType, u32>,
}
Copy link
Collaborator

@gabrielbosio gabrielbosio Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to add more fields in this struct in the future?

gabrielbosio
gabrielbosio reviewed Feb 9, 2026
View reviewed changes
vm/src/vm/runners/cairo_runner.rs
Comment on lines +1100 to +1102
Ok(ExtendedExecutionResources {
extended_resource_counter: self.vm.extended_resource_counter.clone(),
})
Copy link
Collaborator

@gabrielbosio gabrielbosio Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not creating this struct once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielbosio gabrielbosio gabrielbosio left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MeidarSharkansky-starkware @gabrielbosio