perf: remove redundant Felt252 bytes roundtrip in SignatureBuiltinRunner #2323
+9
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Bench results: |
Collaborator
|
@VolodymyrBg what commands did you run to get those results? What are the specs used to run the benchmarks: Rust profile, commit used for the "Before" case, RAM, OS, arch, processor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignatureBuiltinRunnerhad 7 instances ofFelt252::from_bytes_be(&x.to_bytes_be())scattered across 5 methods. These were identity operations — serializing a Felt to a 32-byte array and immediately parsing it back to the same type. This was a leftover from when starknet-crypto used its own FieldElement type and byte conversion was needed to bridge between FieldElement and Felt252. Since the migration to starknet-types-core::Felt (starknet-crypto 0.7+), both sides use the exact same type, making these roundtrips pure overhead.