-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build(core): remove jobs from pr and add to merge group. (#1260)
**Motivation** There are jobs that are quite unrelated to the files that have been changed, but still could cause an issue in an edge case. Let's run these tests on the merge queue instead of CI. The main idea is that a job should be either in pull request or in merge group. Jobs on pull requests should be the jobs that test code that was changed and merge queues tests code that is probably unrelated but we want a sanity check before merging **Description** - Moved several heavy tests from CI (on pull request) to merge group - Various formatting and consistency changes. - Removed "ci skipped" hack since we already include those jobs in the merge queue
- Loading branch information
Showing
10 changed files
with
52 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,37 @@ | ||
name: Docker build | ||
|
||
on: | ||
workflow_call: | ||
workflow_call: | ||
merge_group: | ||
pull_request: | ||
branches: ["**"] | ||
paths-ignore: | ||
- "README.md" | ||
- "LICENSE" | ||
- "**/README.md" | ||
- "**/docs/**" | ||
|
||
jobs: | ||
docker_build: | ||
name: Docker Build image | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
docker_build: | ||
name: Docker Build image | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Build Docker image | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
file: ./Dockerfile | ||
load: true | ||
tags: ethrex | ||
outputs: type=docker,dest=/tmp/ethrex_image.tar | ||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: ethrex_image | ||
path: /tmp/ethrex_image.tar | ||
- name: Build Docker image | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
file: ./Dockerfile | ||
load: true | ||
tags: ethrex | ||
outputs: type=docker,dest=/tmp/ethrex_image.tar | ||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: ethrex_image | ||
path: /tmp/ethrex_image.tar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
name: L2 Contracts CI | ||
on: | ||
push: | ||
branches: ["main"] | ||
merge_group: | ||
paths: | ||
- "crates/l2/contracts/**" | ||
pull_request: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: "Lint PR title" | ||
name: Lint PR title | ||
|
||
on: | ||
merge_group: | ||
|