Skip to content

Commit

Permalink
ci(core): fix reports to slack channels (#1744)
Browse files Browse the repository at this point in the history
**Motivation**
Lets go back to the previous l1 slack channel for reports

**Description**
- Fixes issue with commas that break the for loop (should be only
spaces)
- Added some linting and safety code
  • Loading branch information
mpaulucci authored Jan 20, 2025
1 parent bbf6734 commit 709f8a2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_gha.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
pull_request:
branches: ["**"]
paths:
".github/**.yaml"
- ".github/**.yaml"

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily_loc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ jobs:
${{ github.event_name == 'workflow_dispatch'
&& secrets.TEST_CHANNEL_SLACK
|| format(
'{0}, {1}, {2}',
secrets.ETHREX_REPORTS_SLACK_WEBHOOK,
'{0} {1} {2}',
secrets.ETHREX_L1_SLACK_WEBHOOK,
secrets.ETHREX_L2_SLACK_WEBHOOK,
secrets.LEVM_SLACK_WEBHOOK
)
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/daily_reports.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ jobs:
${{ github.event_name == 'workflow_dispatch'
&& secrets.TEST_CHANNEL_SLACK
|| format(
'{0}, {1}',
secrets.ETHREX_REPORTS_SLACK_WEBHOOK,
'{0} {1} {2}',
secrets.ETHREX_L1_SLACK_WEBHOOK,
secrets.ETHREX_L2_SLACK_WEBHOOK,
secrets.LEVM_SLACK_WEBHOOK
)
}}
Expand Down Expand Up @@ -196,4 +197,4 @@ jobs:
&& secrets.TEST_CHANNEL_SLACK
|| secrets.LEVM_SLACK_WEBHOOK
}}
run: sh .github/scripts/publish_levm_ef_tests.sh $SLACK_WEBHOOK
run: sh .github/scripts/publish_levm_ef_tests.sh "$SLACK_WEBHOOK"

0 comments on commit 709f8a2

Please sign in to comment.