refactor(l2): handle not committed block #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
force-pushed
the
l2/handle_not_committed_block
branch
from
94a1a89 to
a195fe5
Compare
ilitteri
previously approved these changes
Nov 19, 2024
ilitteri
dismissed
their stale review
The PR was converted into draft during the review.
jrchatruc
reviewed
Nov 20, 2024
crates/l2/proposer/prover_server.rs
Outdated
| } | ||
| Err(e) => { | ||
| error!("Failed to send proof to block {block_number:#x}. Manual intervention required: {e}"); | ||
| panic!("Failed to send proof to block {block_number:#x}. Manual intervention required: {e}"); |
There was a problem hiding this comment.
Instead of panicking here, let's just backoff, wait a while and try sending the transaction again. An error when sending the proof (or on any other request to the L1 for that matter) is something that can (and will) happen every now and then. Anywhere where we interact with L1 we should follow a pattern like this; retry after a little while, not panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
prover_serverwas sending blocks to prove even if the block had not been committed. While this approach helped avoid keeping theproverin an idle state, in practice, the prover is typically slower than the commitment process. Therefore, waiting for the block to be committed provides an additional safety measure.Description
prover_serverqueries the OnChainProposer for thelastCommittedBlockafter receiving aRequestfrom theprover_client.requirestatements of issue L2: DifferentiaterequireErrors in OnChainProposer Verification #1164 were added.Closes #1165
Closes #1164