feat(levm): ensure returned errors are correct #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximopalopoli
added
ef-tests
JereSalo
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
In exception_is_expected() it would be good if all returned errors were implemented (except for the TYPE 3 FORK error).
Anyway, it looks good to me. I would have liked to test what happens if I change something in the matches! to see it breaking, but it looks like it works fine.
For merging don't forget to comment any added println! for debugging
maximopalopoli
merged commit 55517d5
into
levm/fixing_ef_tests_execution
20 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
**Motivation** This PR is a revival of an older PR that implemented this feature, and merged the branch in another which PR was closed. This is an adaptation of it to the current codebase. **Description** See #1225 for more details. --------- Co-authored-by: JereSalo <jeresalo17@gmail.com> Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently in EF tests we don't verify that the error returned by levm matches with the expected, the goal is to verify it, and print an error if it does not match.
Description
This PR includes:
exception_is_expected()