Merged
Conversation
This change was made when fixing a test, in which the target account and the current account were the same. The target, when modified after the current account but accessed before the modification, was not taking the change into account.
maximopalopoli
added
testing
ilitteri
reviewed
Nov 28, 2024
ilitteri
reviewed
Nov 28, 2024
ilitteri
reviewed
Nov 28, 2024
ilitteri
reviewed
Nov 28, 2024
ilitteri
reviewed
Nov 28, 2024
ilitteri
requested changes
Nov 28, 2024
Collaborator
ilitteri
left a comment
ilitteri
left a comment
There was a problem hiding this comment.
The PR looks good. Left some comments.
This reverts commit ceb79b0.
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** The goal is to make the tests of VMTests folder of EF tests. **Description** Currently, are passing 7/11 of the VMTests/vmTests folder. Closes #issue_number --------- Co-authored-by: ilitteri <ilitteri@fi.uba.ar> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The goal is to make the tests of VMTests folder of EF tests.
Description
Currently, are passing 7/11 of the VMTests/vmTests folder.
Closes #issue_number