Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(levm): ci: compare against new benchmarks in main #1834

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

dsocolobsky
Copy link
Contributor

@dsocolobsky dsocolobsky commented Jan 29, 2025

Motivation

Since the recently #1803 PR we now have new benchmarks. We need to modify the CI to make the comparison.
I couldn't do that in the previous PR because since the new benchmarks were not in main yet, the CI would always fail.

Description
I will fix this in the next benchmark PR so we don't have to create 2 PRs for each new benchmark.

@dsocolobsky dsocolobsky requested a review from a team as a code owner January 29, 2025 15:58
@dsocolobsky dsocolobsky changed the title fix(ci): compare against new benchmarks in main chore(levm): ci: compare against new benchmarks in main Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

| File                                                                                            | Lines | Diff |
+-------------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/lib.rs                                       | 17    | -1   |
+-------------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/arithmetic.rs                | 222   | +6   |
+-------------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/bitwise_comparison.rs        | 235   | +3   |
+-------------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/stack_memory_storage_flow.rs | 273   | +3   |
+-------------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/opcode_handlers/system.rs                    | 665   | +3   |
+-------------------------------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/vm.rs                                        | 928   | +210 |
+-------------------------------------------------------------------------------------------------+-------+------+

Total lines added: +225
Total lines removed: 1
Total lines changed: 226

This is mostly because when we are adding a new benchmark in a PR; the benchmark won't be yet available in main, therefore the CI will fail.
@ilitteri ilitteri enabled auto-merge January 29, 2025 18:34
@ilitteri ilitteri added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 10fee17 Jan 29, 2025
20 checks passed
@ilitteri ilitteri deleted the ci/change-bench-reports branch January 29, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants