Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(l1): rename ef_tests-ethrex crate to ef_tests-blockchain and cleanup #1878

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

mpaulucci
Copy link
Collaborator

@mpaulucci mpaulucci commented Feb 6, 2025

Motivation
We should try to be close to the naming used by the Ethereum foundation, they call these tests "Blockchain tests".

Next step is to rename the other one to "State tests".

See: https://ethereum.github.io/execution-spec-tests/main/consuming_tests/blockchain_test/

Description

  • Renamed ef_tests-ethrex to ef_tests-blockchain
  • Moved Makefile specific targets to it's own Makefile
  • Simplified the Makefile
  • From the root Makefile, we can call the ef_tests one with $(MAKE) -C cmd/ef_tests/blockchain test.
  • Added README file.

@mpaulucci mpaulucci requested a review from a team as a code owner February 6, 2025 13:06
@mpaulucci mpaulucci changed the title chore: rename ef_tests-ethrex crate to ef_tests-blockchain and cleanup chore(l1): rename ef_tests-ethrex crate to ef_tests-blockchain and cleanup Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

| File                                                                   | Lines | Diff |
+------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/blockchain/lib.rs         | 3     | +3   |
+------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/blockchain/network.rs     | 79    | +79  |
+------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/blockchain/test_runner.rs | 137   | +137 |
+------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/blockchain/types.rs       | 384   | +384 |
+------------------------------------------------------------------------+-------+------+

Total lines added: +603
Total lines removed: 0
Total lines changed: 603

Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mpaulucci mpaulucci added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 2837eb3 Feb 6, 2025
20 checks passed
@mpaulucci mpaulucci deleted the rename-ethrex-blockchain branch February 6, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants