feat: Add Unit Tests for get_batch_pubdata endpoint #160
Open
toni-calvin wants to merge 15 commits intofeat_get_pubdata_endpointfrom
Open
feat: Add Unit Tests for get_batch_pubdata endpoint #160toni-calvin wants to merge 15 commits intofeat_get_pubdata_endpointfrom
get_batch_pubdata endpoint #160toni-calvin wants to merge 15 commits intofeat_get_pubdata_endpointfrom
Conversation
get_batch_pubdata endpoint in EthSender Moduleget_batch_pubdata endpoint
get_batch_pubdata endpoint get_batch_pubdata endpoint
9fdd035 to
75271c5
Compare
…'s no pubdata in the requested batch
b5a3e35 to
421897f
Compare
jordibonet-lambdaclass
suggested changes
Mar 25, 2024
| .map(|l1_batch_with_metadata| { | ||
| let partial_pubdata = l1_batch_with_metadata.construct_pubdata(); | ||
| // The encoding of empty pubdata results in a vector of zeroes. We should return | ||
| // `None in this case. |
There was a problem hiding this comment.
I think you accidentally left out the character ` before None.
| let partial_pubdata = l1_batch_with_metadata.construct_pubdata(); | ||
| // The encoding of empty pubdata results in a vector of zeroes. We should return | ||
| // `None in this case. | ||
| if partial_pubdata == vec![0u8; partial_pubdata.len()] { |
There was a problem hiding this comment.
Could we consider using iter().all() to compare if all elements of partial_pubdata are zeroes?
This approach can potentially optimize performance by avoiding unnecessary allocation of a new vector of zeroes, particularly beneficial for larger vectors. The suggested change would look like:
if partial_pubdata.iter().all(|&x| x == 0) {
Bytes::default()
} else {
partial_pubdata.into()
}Your thoughts on this optimization would be appreciated. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Overview:
Changes Made:
For running the test:
zk test rust -- get_batch_pubdata_impl --nocapture