Skip to content

fix: Remove validium_mode_example crate#161

Merged
mationorato merged 1 commit intofeat_validium_pubdata_abstractionfrom
remove_validium_mode_example_crate
Feb 21, 2024
Merged

fix: Remove validium_mode_example crate#161
mationorato merged 1 commit intofeat_validium_pubdata_abstractionfrom
remove_validium_mode_example_crate

Conversation

@ilitteri
Copy link
Copy Markdown
Collaborator

This crate was meant for development. Nevertheless, we now have #144 to test the same.

Copy link
Copy Markdown

@jordibonet-lambdaclass jordibonet-lambdaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown

@toni-calvin toni-calvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mationorato
Copy link
Copy Markdown
Collaborator

We should move this example to another branch. It is still useful and practical.

@mationorato
Copy link
Copy Markdown
Collaborator

I moved it here #175

Resolves #163.

Now we can merge.

@mationorato mationorato merged commit 82efd79 into feat_validium_pubdata_abstraction Feb 21, 2024
@mationorato mationorato deleted the remove_validium_mode_example_crate branch February 21, 2024 19:44
toni-calvin pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove validium_mode_example crate

4 participants