Skip to content

Eigenda single config #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Eigenda single config #421

merged 6 commits into from
May 23, 2025

Conversation

gianbelinche
Copy link

What ❔

This PR modifies the config to make it simpler, so that both versions share the same config.

Why ❔

Is this a breaking change?

  • Yes
  • No

Operational changes

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

Copy link

github-actions bot commented May 21, 2025

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Eigenda single config". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

# custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults
cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162
blob_version: 0
polynomial_form: coeff

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reorganize this config a bit:

da_dispatcher:
  use_dummy_inclusion_data: true
da_client:
  client: EigenDA
  version: V1
  disperser_rpc: https://disperser-testnet-holesky.eigenda.xyz
  eigenda_eth_rpc: https://ethereum-holesky-rpc.publicnode.com
  authenticated: true
  settlement_layer_confirmation_depth: 0
  eigenda_svc_manager_address: 0xD4A7E1Bd8015057293f0D0A557088c286942e84b
  wait_for_finalization: false
  points:
    source: Url
    g1_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g1.point
    g2_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g2.point.powerOf2
    # source: Path # uncomment to use Path
    # path: ./resources
  # custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults
  # Fields bellow are unused in V1
  cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162
  blob_version: 0
  polynomial_form: coeff

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep both configs in the same order, so that it is obvious that the only change is the version, I will put the version field at the top though

# custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults
cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162
blob_version: 0
polynomial_form: coeff
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

da_dispatcher:
  use_dummy_inclusion_data: true
da_client:
  client: EigenDA
  version: V2
  disperser_rpc: https://disperser-testnet-holesky.eigenda.xyz
  eigenda_eth_rpc: https://ethereum-holesky-rpc.publicnode.com
  cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162
  blob_version: 0
  polynomial_form: coeff
  # Fields bellow are unused in V2
  authenticated: true
  settlement_layer_confirmation_depth: 0
  eigenda_svc_manager_address: 0xD4A7E1Bd8015057293f0D0A557088c286942e84b
  wait_for_finalization: false
  points:
    source: Url
    g1_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g1.point
    g2_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g2.point.powerOf2
    # source: Path # uncomment to use Path
    # path: ./resources
  # custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep both configs in the same order, so that it is obvious that the only change is the version, I will put the version field at the top though

@gianbelinche gianbelinche changed the title Eigenda mono config Eigenda single config May 23, 2025
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianbelinche gianbelinche merged commit 87d0ef0 into eigenda-v2-m0 May 23, 2025
12 of 30 checks passed
@gianbelinche gianbelinche deleted the eigenda-mono-config branch May 23, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants