-
Notifications
You must be signed in to change notification settings - Fork 1
Eigenda single config #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
# custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults | ||
cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162 | ||
blob_version: 0 | ||
polynomial_form: coeff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reorganize this config a bit:
da_dispatcher:
use_dummy_inclusion_data: true
da_client:
client: EigenDA
version: V1
disperser_rpc: https://disperser-testnet-holesky.eigenda.xyz
eigenda_eth_rpc: https://ethereum-holesky-rpc.publicnode.com
authenticated: true
settlement_layer_confirmation_depth: 0
eigenda_svc_manager_address: 0xD4A7E1Bd8015057293f0D0A557088c286942e84b
wait_for_finalization: false
points:
source: Url
g1_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g1.point
g2_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g2.point.powerOf2
# source: Path # uncomment to use Path
# path: ./resources
# custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults
# Fields bellow are unused in V1
cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162
blob_version: 0
polynomial_form: coeff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep both configs in the same order, so that it is obvious that the only change is the version, I will put the version field at the top though
# custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults | ||
cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162 | ||
blob_version: 0 | ||
polynomial_form: coeff | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
da_dispatcher:
use_dummy_inclusion_data: true
da_client:
client: EigenDA
version: V2
disperser_rpc: https://disperser-testnet-holesky.eigenda.xyz
eigenda_eth_rpc: https://ethereum-holesky-rpc.publicnode.com
cert_verifier_addr: 0xfe52fe1940858dcb6e12153e2104ad0fdfbe1162
blob_version: 0
polynomial_form: coeff
# Fields bellow are unused in V2
authenticated: true
settlement_layer_confirmation_depth: 0
eigenda_svc_manager_address: 0xD4A7E1Bd8015057293f0D0A557088c286942e84b
wait_for_finalization: false
points:
source: Url
g1_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g1.point
g2_url: https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g2.point.powerOf2
# source: Path # uncomment to use Path
# path: ./resources
# custom_quorum_numbers: 2,3 # uncomment to use other quorums besides defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep both configs in the same order, so that it is obvious that the only change is the version, I will put the version field at the top though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What ❔
This PR modifies the config to make it simpler, so that both versions share the same config.
Why ❔
Is this a breaking change?
Operational changes
Checklist
zkstack dev fmt
andzkstack dev lint
.