Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped ansi-wl-pprint to 1.0.2 and everything seems to build fine. #59

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

erlandsona
Copy link
Collaborator

Haven't done any testing tho 🤔.

@lambdageek Anything, I should be looking for specifically?

unbound-generics.cabal Outdated Show resolved Hide resolved
@lambdageek
Copy link
Owner

Generally I just try to run some of the examples locally and look at the output.

To be honest I don't remember why we even have a pprint dependency. Do we have pretty printer instances for the language combinators?

@lambdageek
Copy link
Owner

One thing you should probably do is get familiar with ghcup and building unbound-generics with older versions of ghc. Most of our problems with version bumps happen when an older compiler doesn't like new code for some reason.

I generally try to keep everything working with old versions of GHC because sometimes academic projects use us (like some student will do a master's thesis project or something) and they generally don't update after the paper is done. And if someone comes along and tries to use their project later, it's nice if they can still build it.

That said, if some 10-year version of GHC doesn't build in Github Actions anymore, I don't feel too bad about dropping support. (Like with 7.10 earlier this year)

@lambdageek lambdageek merged commit 7ce8463 into lambdageek:main Sep 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants