-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ~ should be escaped #20
Conversation
as it has the special functionality :h ~/ ~ matches the last given substitute string */~* */\~* Otherwise, following search fails with error /<c-r>=kensaku#query('a~')<cr><cr> E33: No previous substitute regular expression E383: Invalid search string: \m\%(a~\|あ〜\|ア〜\|a~\|ア〜\)
WalkthroughThe changes in this pull request involve an update to the escape character string in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)autoload/kensaku/rxop.vim (1)
The addition of Let's verify if there are any other files that might need similar escaping: ✅ Verification successfulThe tilde escaping change is correctly implemented and complete After reviewing all regex-related configurations in the codebase:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for other potential locations where tilde escaping might be needed
# Look for regex-related configurations or tilde character handling
# Search for files containing regex operator configurations
rg -l 'escape.*[''"]\\.'
# Search for files containing tilde character handling
rg -l '[''"]~[''"]'
Length of output: 67 Script: #!/bin/bash
# Let's check the content of migemo.ts to understand its regex escaping
cat denops/kensaku/migemo.ts
# Also, let's do a broader search for escape patterns with single quotes
rg -l "escape.*'\\\."
# And search for tilde-related patterns with single quotes
rg -l "'~'"
Length of output: 2874 Script: #!/bin/bash
# Let's check the content of doc/kensaku.jax to see its escape pattern usage
cat doc/kensaku.jax
# Let's also check if there are any other regex-related configurations
rg -A 5 -B 5 'escape.*[''"]\\.' autoload/kensaku/rxop.vim
Length of output: 4476 Script: #!/bin/bash
# Let's see the full context of rxop.vim to understand all regex configurations
cat autoload/kensaku/rxop.vim
Length of output: 475 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
requires latest vim-kensaku lambdalisue/vim-kensaku#20
as it has the special functionality
Otherwise, following search fails with error
Summary by CodeRabbit
New Features
Bug Fixes