Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ~ should be escaped #20

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Nov 26, 2024

as it has the special functionality

:h /~
~	matches the last given substitute string	*/~* */\~*

Otherwise, following search fails with error

/<c-r>=kensaku#query('a~')<cr><cr>

E33: No previous substitute regular expression
E383: Invalid search string: \m\%(a~\|あ〜\|ア〜\|a~\|ア〜\)

Summary by CodeRabbit

  • New Features

    • Updated the escape character string in the Kensaku plugin configuration, enhancing the handling of regular expressions.
  • Bug Fixes

    • Improved character treatment in regular expressions for better functionality within Vim.

as it has the special functionality

    :h ~/
    ~	matches the last given substitute string	*/~* */\~*

Otherwise, following search fails with error

    /<c-r>=kensaku#query('a~')<cr><cr>

    E33: No previous substitute regular expression
    E383: Invalid search string: \m\%(a~\|あ〜\|ア〜\|a~\|ア〜\)
Copy link

coderabbitai bot commented Nov 26, 2024

Walkthrough

The changes in this pull request involve an update to the escape character string in the g:kensaku#rxop#vim configuration within the autoload/kensaku/rxop.vim file. The escape string has been modified to include a tilde (~), which affects how certain characters are processed in regular expressions for the Kensaku plugin in Vim. No other changes to logic or error handling are included.

Changes

File Change Summary
autoload/kensaku/rxop.vim Updated escape string in g:kensaku#rxop#vim from \\.[].*^$ to \\.[].*~^$

Poem

In the land of code where bunnies play,
A tilde hops in, brightening the day.
Regex now dances with a new twist,
In Vim's embrace, it cannot be missed!
So let us cheer for the changes made,
A joyful leap in the coding glade! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f7080a9 and 0621d37.

📒 Files selected for processing (1)
  • autoload/kensaku/rxop.vim (1 hunks)
🔇 Additional comments (1)
autoload/kensaku/rxop.vim (1)

9-9: LGTM! The change correctly addresses the tilde escaping issue.

The addition of ~ to the escape sequence is the right fix for the reported error "E33: No previous substitute regular expression", as it ensures the tilde is treated as a literal character rather than a special Vim substitute pattern matcher.

Let's verify if there are any other files that might need similar escaping:

✅ Verification successful

The tilde escaping change is correctly implemented and complete

After reviewing all regex-related configurations in the codebase:

  1. The tilde (~) is only needed in the Vim regex operator (g:kensaku#rxop#vim) as it's a Vim-specific special character
  2. The JavaScript regex operator (g:kensaku#rxop#javascript) correctly doesn't include ~ as it's not a special character in JavaScript
  3. The migemo.ts implementation uses a different set of escape characters appropriate for its context
  4. The documentation (kensaku.jax) confirms these are the only two regex operator configurations in the codebase
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for other potential locations where tilde escaping might be needed
# Look for regex-related configurations or tilde character handling

# Search for files containing regex operator configurations
rg -l 'escape.*[''"]\\.' 

# Search for files containing tilde character handling
rg -l '[''"]~[''"]'

Length of output: 67


Script:

#!/bin/bash
# Let's check the content of migemo.ts to understand its regex escaping
cat denops/kensaku/migemo.ts

# Also, let's do a broader search for escape patterns with single quotes
rg -l "escape.*'\\\."

# And search for tilde-related patterns with single quotes
rg -l "'~'"

Length of output: 2874


Script:

#!/bin/bash
# Let's check the content of doc/kensaku.jax to see its escape pattern usage
cat doc/kensaku.jax

# Let's also check if there are any other regex-related configurations
rg -A 5 -B 5 'escape.*[''"]\\.' autoload/kensaku/rxop.vim

Length of output: 4476


Script:

#!/bin/bash
# Let's see the full context of rxop.vim to understand all regex configurations
cat autoload/kensaku/rxop.vim

Length of output: 475


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lambdalisue lambdalisue merged commit 67727c8 into lambdalisue:main Nov 26, 2024
1 check passed
atusy added a commit to atusy/jab.nvim that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants