Skip to content

Bump coding standard #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Aug 11, 2022

Q A
QA yes

Description

This updates to the latest coding standard. Therefore, we can stop ignoring the PHP platform requirement for PHP 8.1 as the latest coding standard supports PHP 8.1.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
The CI matrix generator detects the extension requirement from the `composer.json` and due to the update to the latest coding standard, we can finally respect the PHP platform requirement

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added this to the 2.1.0 milestone Aug 11, 2022
@boesing boesing merged commit 54a0c7b into laminas:2.1.x Aug 11, 2022
@boesing boesing deleted the qa/bump-coding-standard branch August 11, 2022 16:54
@Ocramius
Copy link
Member

Installing packaged extensions: php8.0-mongodb

Happens automatically? Nice!

@boesing
Copy link
Member Author

boesing commented Aug 11, 2022

Yes, the matrix container is able to extract required extensions from composer.json.
Next step will be detecting extensions from composer.lock as per request from one of your issues where I've seen that this was an issue:

laminas/laminas-ci-matrix-action#91

But this will only work for projects with a composer.lock ofc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants