Skip to content

Commit

Permalink
qa: synchronize package.json and package-lock.json with `Dockerfi…
Browse files Browse the repository at this point in the history
…le` version of `node`

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
  • Loading branch information
boesing committed Apr 24, 2024
1 parent b55efa6 commit 729b121
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
- uses: "actions/setup-node@v4"
with:
check-latest: true
node-version: 20
node-version: 21
- name: "Install node modules"
run: "npm ci"
- name: Run ESLint
Expand All @@ -149,7 +149,7 @@ jobs:
- uses: "actions/setup-node@v4"
with:
check-latest: true
node-version: 20
node-version: 21
- name: "Install node modules"
run: "npm ci"
- name: Run Jest
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ COPY package*.json ./
COPY tsconfig.json ./
COPY webpack.config.ts ./
RUN npm ci
RUN apk add --no-cache jq && npx semver -r $(jq -r '.packages."".engines.node' package-lock.json) $(node -v) || >&2 echo "ERROR: package-lock.json is not synchronized with Dockerfile node version." && exit 1
COPY ./src ./src
RUN npm run build

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"engines": {
"npm": "^10.0.0",
"node": "^20.2.0"
"node": "^21.7.0"
},
"dependencies": {
"@actions/core": "^1.10.0",
Expand Down

0 comments on commit 729b121

Please sign in to comment.