Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan tooling detection #318

Merged
merged 4 commits into from
Dec 9, 2024
Merged

PHPStan tooling detection #318

merged 4 commits into from
Dec 9, 2024

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 26, 2024

Q A
Documentation yes
New Feature yes

Description

Introduce PHPStan

@boesing
qa: introduce tests for phpstan tool detection
c280446 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
feature: introduce phpstan tool detection
d3e4794 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
docs: add PHPStan detection logic to README
32b63c2 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added this to the 1.28.0 milestone Sep 26, 2024
@boesing
refactor: move some tools to dedicated files
6fcdd55 
Due to the new PHPStan tool, we exceeded the line-length limit of 100 lines per file.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Copy link
Member Author

boesing commented Sep 26, 2024

FYI: Had to refactor a bit since eslint did not pass due to maximum line-length per-file of 100 lines 🫠

@boesing boesing requested review from Xerkus and gsteel September 26, 2024 16:26
gsteel
gsteel approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boesing - This looks perfect afaict 👍

@alexmerlin
Copy link
Member

@boesing Could you also fix the small error reported under the Unchanged files with check annotations section?

@gsteel gsteel self-assigned this Dec 9, 2024
@gsteel
Copy link
Member

gsteel commented Dec 9, 2024

It's been several months so I'm merging and releasing this without further review.

@gsteel gsteel merged commit 0f1be7a into laminas:1.28.x Dec 9, 2024
48 checks passed
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Merged
@Ocramius
Copy link
Member

Just dropping it here, but apparently, I get PHPStan runs even for repos that don't have PHPStan?

https://github.com/Roave/SecurityAdvisoriesBuilder/actions/runs/12371968284/job/34529270030?pr=759

@Ocramius Ocramius mentioned this pull request Dec 17, 2024
Merged
@gsteel
Copy link
Member

gsteel commented Dec 17, 2024

Just dropping it here, but apparently, I get PHPStan runs even for repos that don't have PHPStan?

@Ocramius

That's expected if you've got a PHPStan config file in the root directory no? Same as Psalm, PHPUnit etc

https://github.com/Roave/SecurityAdvisoriesBuilder/blob/latest/phpstan.neon.dist

@Ocramius
Copy link
Member

ZOMG I'm blind 🤦

@boesing boesing deleted the feature/phpstan branch January 17, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel approved these changes

@Xerkus Xerkus Awaiting requested review from Xerkus

Assignees

@gsteel gsteel

Labels
Enhancement
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@boesing @alexmerlin @gsteel @Ocramius