Skip to content

feature: introduce CI #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 28, 2022
Merged

feature: introduce CI #62

merged 22 commits into from
Jun 28, 2022

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 24, 2021

Q A
New Feature yes
QA yes

Description

Initial work on adding CI pipeline for the matrix action.

@boesing boesing added this to the 1.11.0 milestone Sep 24, 2021
@boesing boesing marked this pull request as draft September 24, 2021 14:50
@boesing boesing mentioned this pull request Sep 24, 2021
Merged
@boesing boesing force-pushed the feature/continious-integration branch from 48f3322 to d7d29a1 Compare September 24, 2021 14:56
@boesing
Copy link
Member Author

boesing commented Sep 24, 2021

I see, we need a slightly changed container so it does not always do the composer magic...

@boesing boesing removed this from the 1.11.0 milestone Oct 5, 2021
@boesing boesing changed the base branch from 1.11.x to 1.12.x October 10, 2021 18:24
@boesing boesing mentioned this pull request Jan 20, 2022
Merged
@boesing boesing mentioned this pull request Mar 3, 2022
Closed
@boesing boesing mentioned this pull request Mar 24, 2022
Closed
boesing added 3 commits March 24, 2022 23:33
@boesing
feature: introduce CI
a78f651 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
qa: introduce additional checks
57edf15 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
feature: modify continuous integration to iterate over test projects
2abcb4e 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the feature/continious-integration branch from d7d29a1 to 2abcb4e Compare March 24, 2022 22:57
boesing added 5 commits March 24, 2022 23:58
@boesing
bugfix: checkout code before generating the matrix
69f7cd9 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: return JSON array as matrix output
1b31ab9 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: remove fromJSON from matrix
7e95c31 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: use proper set-output notation to provide JSON array
b3d7262 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: use alternative notation to output variable
e9a23c4 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This was referenced Mar 25, 2022
Merged
Closed
@boesing boesing mentioned this pull request Apr 5, 2022
Closed
boesing added 7 commits April 7, 2022 00:51
@boesing
qa: add some project structures for integration testing
263af90 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
refactor: build docker container and use it within build steps
cd86164 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: fixup container filename
dd7ef62 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: checkout source code
4be073d 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
feature: use github action cache for container build
3b82981 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: use -it rather than --it
454ac89 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: remove interactive tty from docker run
92f93aa 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing added 6 commits April 7, 2022 01:25
@boesing
bugfix: use TEST_TAG as container identifier
2f92a40 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
feature: output generated matrix from matrix_generation step
2efe76c 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: properly escape JSON output
a963e94 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: change to <=8.1.0 since , constraint is not supported (yet)
503b791 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: add missing s to docs
e514d80 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
bugfix: escape JSON for verification
a945d27 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@ghostwriter ghostwriter mentioned this pull request May 15, 2022
Closed
@boesing
Copy link
Member Author

boesing commented Jun 8, 2022

@weierophinney Any chance that we get this merged?
I've added plenty of tests already and would be happy to take this as a base for #83 so we can finally ship that whole thing.

@boesing boesing marked this pull request as ready for review June 8, 2022 22:50
Ocramius
Ocramius approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO 🚢

Possibly worth merging this one before #83, to see if we are at parity too.

@Ocramius Ocramius added this to the 1.12.0 milestone Jun 28, 2022
@boesing
docs: add some clarification on why we generate a matrix here
eef730a 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing merged commit 884b1d0 into laminas:1.12.x Jun 28, 2022
@boesing boesing deleted the feature/continious-integration branch June 28, 2022 13:15
@boesing boesing mentioned this pull request Jun 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boesing @Ocramius