Merge pull request #19 from fezfez/deprecation-message

fix deprecation message for php 8.1 +  drop php 7.3 support

composer.json

@@ -25,7 +25,7 @@
         }
     },
     "require": {
-        "php": "^7.3 || ~8.0.0 || ~8.1.0",
+        "php": "^7.4 || ~8.0.0 || ~8.1.0",
         "ext-dom": "*",
         "ext-libxml": "*"
     },

phpunit.xml.dist

@@ -2,6 +2,9 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
         bootstrap="vendor/autoload.php"
+        convertErrorsToExceptions="true"
+        convertNoticesToExceptions="true"
+        convertWarningsToExceptions="true"
         colors="true">
   <coverage processUncoveredFiles="true">
     <include>

src/Document/NodeList.php

@@ -10,6 +10,7 @@
 use DOMNodeList;
 use Iterator;
 use Laminas\Dom\Exception;
+use ReturnTypeWillChange;
 
 /**
  * DOMNodeList wrapper for Laminas\Dom\Document\Query results
@@ -39,6 +40,7 @@ public function __construct(DOMNodeList $list)
      *
      * @return DOMNode
      */
+    #[ReturnTypeWillChange]
     public function rewind()
     {
         $this->position = 0;
@@ -51,6 +53,7 @@ public function rewind()
      *
      * @return bool
      */
+    #[ReturnTypeWillChange]
     public function valid()
     {
         return $this->offsetExists($this->position);
@@ -61,6 +64,7 @@ public function valid()
      *
      * @return DOMNode
      */
+    #[ReturnTypeWillChange]
     public function current()
     {
         return $this->list->item($this->position);
@@ -71,6 +75,7 @@ public function current()
      *
      * @return int
      */
+    #[ReturnTypeWillChange]
     public function key()
     {
         return $this->position;
@@ -81,6 +86,7 @@ public function key()
      *
      * @return DOMNode
      */
+    #[ReturnTypeWillChange]
     public function next()
     {
         ++$this->position;
@@ -93,6 +99,7 @@ public function next()
      *
      * @return int
      */
+    #[ReturnTypeWillChange]
     public function count()
     {
         return $this->list->length;
@@ -104,6 +111,7 @@ public function count()
      * @param int $key
      * @return bool
      */
+    #[ReturnTypeWillChange]
     public function offsetExists($key)
     {
         // DOMNodeList return `null` if item not exists.
@@ -116,6 +124,7 @@ public function offsetExists($key)
      * @param int $key
      * @return mixed
      */
+    #[ReturnTypeWillChange]
     public function offsetGet($key)
     {
         return $this->list->item($key);
@@ -128,6 +137,7 @@ public function offsetGet($key)
      * @param  mixed $value
      * @throws Exception\BadMethodCallException When attempting to write to a read-only item.
      */
+    #[ReturnTypeWillChange]
     public function offsetSet($key, $value)
     {
         throw new Exception\BadMethodCallException('Attempting to write to a read-only list');
@@ -139,6 +149,7 @@ public function offsetSet($key, $value)
      * @param  mixed $key
      * @throws Exception\BadMethodCallException When attempting to unset a read-only item.
      */
+    #[ReturnTypeWillChange]
     public function offsetUnset($key)
     {
         throw new Exception\BadMethodCallException('Attempting to unset on a read-only list');

src/NodeList.php

@@ -10,6 +10,7 @@
 use DOMNode;
 use DOMNodeList;
 use Iterator;
+use ReturnTypeWillChange;
 
 use function in_array;
 use function range;
@@ -118,6 +119,7 @@ public function getContextNode()
      *
      * @return DOMNode
      */
+    #[ReturnTypeWillChange]
     public function rewind()
     {
         $this->position = 0;
@@ -130,6 +132,7 @@ public function rewind()
      *
      * @return bool
      */
+    #[ReturnTypeWillChange]
     public function valid()
     {
         if (in_array($this->position, range(0, $this->nodeList->length - 1)) && $this->nodeList->length > 0) {
@@ -144,6 +147,7 @@ public function valid()
      *
      * @return DOMNode
      */
+    #[ReturnTypeWillChange]
     public function current()
     {
         return $this->nodeList->item($this->position);
@@ -154,6 +158,7 @@ public function current()
      *
      * @return int
      */
+    #[ReturnTypeWillChange]
     public function key()
     {
         return $this->position;
@@ -164,6 +169,7 @@ public function key()
      *
      * @return DOMNode
      */
+    #[ReturnTypeWillChange]
     public function next()
     {
         ++$this->position;
@@ -176,6 +182,7 @@ public function next()
      *
      * @return int
      */
+    #[ReturnTypeWillChange]
     public function count()
     {
         return $this->nodeList->length;
@@ -187,6 +194,7 @@ public function count()
      * @param int $key
      * @return bool
      */
+    #[ReturnTypeWillChange]
     public function offsetExists($key)
     {
         if (in_array($key, range(0, $this->nodeList->length - 1)) && $this->nodeList->length > 0) {
@@ -201,6 +209,7 @@ public function offsetExists($key)
      * @param int $key
      * @return mixed
      */
+    #[ReturnTypeWillChange]
     public function offsetGet($key)
     {
         return $this->nodeList->item($key);
@@ -213,6 +222,7 @@ public function offsetGet($key)
      * @param  mixed $value
      * @throws Exception\BadMethodCallException When attempting to write to a read-only item.
      */
+    #[ReturnTypeWillChange]
     public function offsetSet($key, $value)
     {
         throw new Exception\BadMethodCallException('Attempting to write to a read-only list');
@@ -224,6 +234,7 @@ public function offsetSet($key, $value)
      * @param  mixed $key
      * @throws Exception\BadMethodCallException When attempting to unset a read-only item.
      */
+    #[ReturnTypeWillChange]
     public function offsetUnset($key)
     {
         throw new Exception\BadMethodCallException('Attempting to unset on a read-only list');