Merge pull request #46 from boesing/bugfix/add-missing-adapter-plugin…

…manager-to-config-provider

Add missing `AdapterPluginManager` service to `ConfigProvider`

composer.json

@@ -37,7 +37,7 @@
     },
     "require-dev": {
         "laminas/laminas-coding-standard": "~2.4.0",
-        "laminas/laminas-math": "~3.6.0",
+        "laminas/laminas-math": "^3.6",
         "laminas/laminas-servicemanager": "~3.19.0",
         "phpunit/phpunit": "~9.6.0"
     },

src/ConfigProvider.php

@@ -10,7 +10,11 @@
 
 use Laminas\Serializer\Adapter\AdapterInterface;
 use Laminas\Serializer\Adapter\PhpSerialize;
+use Psr\Container\ContainerInterface;
 
+/**
+ * @see ContainerInterface
+ */
 class ConfigProvider
 {
     /**
@@ -28,16 +32,24 @@ public function __invoke()
     /**
      * Return dependency mappings for this component.
      *
-     * @return array
+     * @return array{
+     *     factories: array<
+     *      string,
+     *      callable(ContainerInterface,?string,?array<mixed>|null):object
+     *     >,
+     *     aliases: array<never,never>
+     * }
      */
+    // @phpcs:ignore SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint
     public function getDependencyConfig()
     {
         return [
             // Legacy Zend Framework aliases
             'aliases'   => [],
             'factories' => [
-                'SerializerAdapterManager' => AdapterPluginManagerFactory::class,
-                AdapterInterface::class    => new GenericSerializerFactory(PhpSerialize::class),
+                'SerializerAdapterManager'  => AdapterPluginManagerFactory::class,
+                AdapterPluginManager::class => AdapterPluginManagerFactory::class,
+                AdapterInterface::class     => new GenericSerializerFactory(PhpSerialize::class),
             ],
         ];
     }

test/ConfigProviderTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Serializer;
+
+use Laminas\Serializer\Adapter\AdapterInterface;
+use Laminas\Serializer\AdapterPluginManager;
+use Laminas\Serializer\ConfigProvider;
+use PHPUnit\Framework\TestCase;
+
+final class ConfigProviderTest extends TestCase
+{
+    /**
+     * @param non-empty-string $serviceName
+     * @dataProvider factoryServiceNames
+     */
+    public function testHasExpectedServiceNames(string $serviceName): void
+    {
+        $dependencies = (new ConfigProvider())->getDependencyConfig();
+        self::assertArrayHasKey($serviceName, $dependencies['factories']);
+    }
+
+    /**
+     * @return iterable<non-empty-string,array{0:non-empty-string}>
+     */
+    public static function factoryServiceNames(): iterable
+    {
+        return [
+            'SerializerAdapterManager'  => ['SerializerAdapterManager'],
+            AdapterPluginManager::class => [AdapterPluginManager::class],
+            AdapterInterface::class     => [AdapterInterface::class],
+        ];
+    }
+}