qa: remove prophecy usage

Substitute phpunit mock objects for all usage of Prophecy in unit tests. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
laminas · Feb 18, 2021 · 8f6c6fd · 8f6c6fd
1 parent 58dad1a
commit 8f6c6fd
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 27 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/test/AdapterPluginManagerFactoryTest.php b/test/AdapterPluginManagerFactoryTest.php
@@ -77,7 +77,7 @@ public function testFactoryConfiguresPluginManagerUnderServiceManagerV2()
 
     public function testConfiguresSerializerServicesWhenFound()
     {
-        $serializer = $this->prophesize(AdapterInterface::class)->reveal();
+        $serializer = $this->createMock(AdapterInterface::class);
         $config = [
             'serializers' => [
                 'aliases' => [
@@ -91,15 +91,24 @@ public function testConfiguresSerializerServicesWhenFound()
             ],
         ];
 
-        $container = $this->prophesize(ServiceLocatorInterface::class);
-        $container->willImplement(ContainerInterface::class);
+        $container = $this->createMock(ContainerInterface::class);
+
+        $container
+            ->expects($this->atLeast(2))
+            ->method('has')
+            ->will($this->returnValueMap([
+                ['ServiceListener', false],
+                ['config', true]
+            ]));
 
-        $container->has('ServiceListener')->willReturn(false);
-        $container->has('config')->willReturn(true);
-        $container->get('config')->willReturn($config);
+        $container
+            ->expects($this->atLeastOnce())
+            ->method('get')
+            ->with('config')
+            ->willReturn($config);
 
         $factory = new AdapterPluginManagerFactory();
-        $serializers = $factory($container->reveal(), 'SerializerAdapterManager');
+        $serializers = $factory($container, 'SerializerAdapterManager');
 
         $this->assertInstanceOf(AdapterPluginManager::class, $serializers);
         $this->assertTrue($serializers->has('test'));
@@ -110,7 +119,7 @@ public function testConfiguresSerializerServicesWhenFound()
 
     public function testDoesNotConfigureSerializerServicesWhenServiceListenerPresent()
     {
-        $serializer = $this->prophesize(AdapterInterface::class)->reveal();
+        $serializer = $this->createMock(AdapterInterface::class);
         $config = [
             'serializers' => [
                 'aliases' => [
@@ -124,15 +133,21 @@ public function testDoesNotConfigureSerializerServicesWhenServiceListenerPresent
             ],
         ];
 
-        $container = $this->prophesize(ServiceLocatorInterface::class);
-        $container->willImplement(ContainerInterface::class);
+        $container = $this->createMock(ContainerInterface::class);
+
+        $container
+            ->expects($this->atLeastOnce())
+            ->method('has')
+            ->with('ServiceListener')
+            ->willReturn(true);
 
-        $container->has('ServiceListener')->willReturn(true);
-        $container->has('config')->shouldNotBeCalled();
-        $container->get('config')->shouldNotBeCalled();
+        $container
+            ->expects($this->never())
+            ->method('get')
+            ->with('config');
 
         $factory = new AdapterPluginManagerFactory();
-        $serializers = $factory($container->reveal(), 'SerializerAdapterManager');
+        $serializers = $factory($container, 'SerializerAdapterManager');
 
         $this->assertInstanceOf(AdapterPluginManager::class, $serializers);
         $this->assertFalse($serializers->has('test'));
@@ -141,30 +156,47 @@ public function testDoesNotConfigureSerializerServicesWhenServiceListenerPresent
 
     public function testDoesNotConfigureSerializerServicesWhenConfigServiceNotPresent()
     {
-        $container = $this->prophesize(ServiceLocatorInterface::class);
-        $container->willImplement(ContainerInterface::class);
+        $container = $this->createMock(ContainerInterface::class);
+
+        $container
+            ->expects($this->atLeast(2))
+            ->method('has')
+            ->will($this->returnValueMap([
+                ['ServiceListener', false],
+                ['config', false]
+            ]));
 
-        $container->has('ServiceListener')->willReturn(false);
-        $container->has('config')->willReturn(false);
-        $container->get('config')->shouldNotBeCalled();
+        $container
+            ->expects($this->never())
+            ->method('get')
+            ->with('config');
 
         $factory = new AdapterPluginManagerFactory();
-        $serializers = $factory($container->reveal(), 'SerializerAdapterManager');
+        $serializers = $factory($container, 'SerializerAdapterManager');
 
         $this->assertInstanceOf(AdapterPluginManager::class, $serializers);
     }
 
     public function testDoesNotConfigureSerializerServicesWhenConfigServiceDoesNotContainSerializersConfig()
     {
-        $container = $this->prophesize(ServiceLocatorInterface::class);
-        $container->willImplement(ContainerInterface::class);
+        $container = $this->createMock(ContainerInterface::class);
+
+        $container
+            ->expects($this->atLeast(2))
+            ->method('has')
+            ->will($this->returnValueMap([
+                ['ServiceListener', false],
+                ['config', true]
+            ]));
 
-        $container->has('ServiceListener')->willReturn(false);
-        $container->has('config')->willReturn(true);
-        $container->get('config')->willReturn(['foo' => 'bar']);
+        $container
+            ->expects($this->atLeastOnce())
+            ->method('get')
+            ->with('config')
+            ->willReturn(['foo' => 'bar']);
 
         $factory = new AdapterPluginManagerFactory();
-        $serializers = $factory($container->reveal(), 'SerializerAdapterManager');
+        $serializers = $factory($container, 'SerializerAdapterManager');
 
         $this->assertInstanceOf(AdapterPluginManager::class, $serializers);
         $this->assertFalse($serializers->has('foo'));