Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null argument to strlen #30

Closed
wants to merge 2 commits into from
Closed

Allow null argument to strlen #30

wants to merge 2 commits into from

Conversation

ittmann
Copy link

@ittmann ittmann commented Jul 5, 2021

Resolves a BC break introduced in 3.4.0
A Fatal Error is thrown when null is passed to StringWrapper/Intl:strlen which was not the case in previous versions

Closes #29

DIReports added 2 commits July 6, 2021 00:15
Signed-off-by: Dick Ittmann <dick.ittmann@reports.nl>
Signed-off-by: Dick Ittmann <dick.ittmann@reports.nl>
@Ocramius
Copy link
Member

Ocramius commented Jul 5, 2021

See laminas/laminas-escaper#20

The correct resolution for this is potentially something like laminas/laminas-escaper#23, not relaxing input types.

The signature of this method has always required a string as input.

@Ocramius Ocramius closed this Jul 5, 2021
@Ocramius Ocramius self-assigned this Jul 5, 2021
@Ocramius Ocramius added Bug Something isn't working Duplicate This issue or pull request already exists Invalid This doesn't seem right labels Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Duplicate This issue or pull request already exists Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Error when StringWrapper/Intl:strlen is passed null (BC break in 3.4.0)
3 participants