Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PHP 8.4 in CI #63

Closed
wants to merge 1 commit into from
Closed

Run PHP 8.4 in CI #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .laminas-ci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,15 @@
{}
{
"additional_checks": [
{
"name": "Run Tests on 8.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary. Even lowest should be properly handled via ignore_php_platform_requirements as we added that newish composer feature: --ignore-platform-req=php+ (which respects upper bounds)

Ref: composer/composer#10318

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nvm:

laminas/laminas-continuous-integration-action#179

Maybe implement that first so we can leave this alone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm just mucking around really - I didn't know how to run checks for PHP versions not listed in composer.json. Led me to find this issue: laminas/laminas-ci-matrix-action#310

"job": {
"php": "8.4",
"dependencies": "latest",
"command": "vendor/bin/phpunit"
}
}
],
"ignore_php_platform_requirements": {
"8.4": true
}
}