Deprecates and replaces the Gravatar helper with a simplified version… #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs another skim before review: CI failing 😁 |
Ocramius
reviewed
Mar 24, 2022
… that achieves the same goal. Signed-off-by: George Steel <george@net-glue.co.uk>
|
@gsteel
|
|
@froschdesign I would leave all notices completely out, for stuff that can be deprecated statically. Notices are only necessary for combinations of input parameters. |
|
@Ocramius I mean the notice in the documentation: https://docs.laminas.dev/laminas-view/helpers/gravatar/ |
|
Sorry @froschdesign - #158 is ready for review :) Would you be able to add recently merged pulls to the v3 project under done? This will help me when it comes to going over the deprecations/removals for the migration guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Gravatar view helper has a tonne of setters and getters, dodgy inheritance and checks out superglobals to figure out if the current http request is secure or not.
The existing helper is deprecated completely in this pull with a replacement implementation that simply spits out an
imgtag with the relevantsrc.Notable differences…
srcto avoid inspecting the requestBecause this was originally part of #146 - it imports the psalm type
AttributeSetfrom HtmlAttributesSet which is added in #146 so psalm qa will fail.Maybe this pull can be left for when/if 146 is merged and then rebased so psalm passes.