[WIP] Add sparse tensor support #12
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Break lots of other broadcasting operations that previously worked but were slow)
Julia did this, not me
|
Hi, thanks for your message! This seems good so far, keep up the work! :) |
It's much quicker
Need to analyse performance of this; suspect most of slowness is in permutedims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with adding sparse tensor support to this package with a simple dictionary-based implementation. For the operations I have implemented it seems to be about 3-4x faster than MATLAB's
tensor_toolbox, which is nice.Please consider this a vomit draft - I haven't had to delve this far into Julia's type system before. I mostly wanted to let people know that I was working on it and perhaps give them the chance to tell me if I was doing anything catastrophically short-sighted.
Implemented so far:
... and not much else.