Skip to content

chore: update lance dependency to v5.1.0-beta.1 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lance-community wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update lance dependency to v5.1.0-beta.1 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugin/trino-lance/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
<dependency>
<groupId>org.lance</groupId>
<artifactId>lance-core</artifactId>
<version>4.0.0</version>
<version>5.1.0-beta.1</version>
<exclusions>
<exclusion>
<groupId>org.junit.jupiter</groupId>
Expand All @@ -128,13 +128,13 @@
<dependency>
<groupId>org.lance</groupId>
<artifactId>lance-namespace-apache-client</artifactId>
<version>0.5.2</version>
<version>0.6.1</version>
</dependency>

<dependency>
<groupId>org.lance</groupId>
<artifactId>lance-namespace-core</artifactId>
<version>0.5.2</version>
<version>0.6.1</version>
</dependency>

<dependency>
Expand Down
8 changes: 3 additions & 5 deletions plugin/trino-lance/src/main/java/io/trino/plugin/lance/LancePageSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import org.lance.FragmentMetadata;
import org.lance.WriteFragmentBuilder;
import org.lance.namespace.LanceNamespace;
import org.lance.namespace.LanceNamespaceStorageOptionsProvider;

import java.util.ArrayList;
import java.util.Collection;
Expand Down Expand Up @@ -185,12 +184,11 @@ private List<String> writeFragments()

if (storageOptions != null && !storageOptions.isEmpty()) {
if (storageOptions.containsKey("expires_at_millis")) {
// Credentials have expiration - use provider for auto-refresh
LanceNamespaceStorageOptionsProvider storageOptionsProvider =
new LanceNamespaceStorageOptionsProvider(namespace, tableId);
// Credentials have expiration - configure namespace client for auto-refresh
fragmentWriter = fragmentWriter
.storageOptions(storageOptions)
.storageOptionsProvider(storageOptionsProvider);
.namespaceClient(namespace)
.tableId(tableId);
}
else {
// Static credentials - use storage options directly without provider
Expand Down
Loading