feat: Create a Exporter class to allow export data from LandingLens #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingruiZhang
reviewed
Feb 8, 2024
| from_date: str | ||
| In date following the format "YYYY-MM-DD" | ||
| save_path: | ||
| Desired path to save the csv file to: '/path/to/save/file.csv' |
There was a problem hiding this comment.
optionally have to_date, if not provided, default to current time.
Comment on lines
+67
to
+70
| def _download_file_from_signed_url(self, signed_url: str, save_path: str) -> None: | ||
| response = requests.get(signed_url) | ||
| with open(save_path, "wb") as file: | ||
| file.write(response.content) |
There was a problem hiding this comment.
Let's just webbrowser.open(signed_url) to directly download the resource through the browser.
| api_key = "land_sk_12345" | ||
| client = Exporter(project_id, api_key) | ||
| res = client.export_event_logs("2021-06-01", "./local/path/to/save/file.csv") | ||
| assert res is None |
There was a problem hiding this comment.
We can return the signed_url and check the return value
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Exporterclass to provide the users with a set of methods to export data from LandingLensexport_event_logs()that allows organization owners the ability to export the event logs of the organization from the given time range.Test
Added unit test