Use OwnedFd instead of RawFd #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0kod
force-pushed
the
ownedfd
branch
6 times, most recently
from
3d839ee to
aed4d81
Compare
Improve consistency by delegating lifetime management to OwnedFd. The only visible change would be that with latest Rust versions, the duplicated file descriptor will be greater than 2 (not with Rust 1.63). See https://doc.rust-lang.org/1.63.0/std/os/unix/io/struct.OwnedFd.html Remove the explicit RulesetCreated's Drop implementation which is now handled by its inner OwnedFd. Replate IntoRawFd with the safer Into<Option<OwnedFd>> for RulesetCreated. The former is implemented for OwnedFd. This is not a breaking change because the IntoRawFd implementation was never released. Add tests leveraging RulesetCreated::try_clone(). Signed-off-by: Mickaël Salaün <mic@digikod.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve consistency by delegating lifetime management to OwnedFd. The only visible change would be that with latest Rust versions, the duplicated file descriptor will be greater than 2 (not with Rust 1.63). See https://doc.rust-lang.org/1.63.0/std/os/unix/io/struct.OwnedFd.html
Remove the explicit RulesetCreated's Drop implementation which is now handled by its inner OwnedFd.
Replate
IntoRawFdwith the saferInto<Option<OwnedFd>>forRulesetCreated. The former is implemented for OwnedFd. This is not a breaking change because the IntoRawFd implementation was never released.Add tests leveraging
RulesetCreated::try_clone().See #85