Feat/dify rag upgrade 0.2.5 #4
Open
+226
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0: - Fix ingest() signature: use IngestionContext -> IngestionResult instead of Any -> Any. Return proper FAILED status with descriptive message instead of None (which would crash downstream model_dump()) P1: - Fix score_threshold schema type: "number" -> "float" (SDK only supports string/text/integer/float/boolean/select) - Fix manifest.yaml component key: "DifyRAGEngine" -> "RAGEngine" to match the component kind convention - Fix delete_document: return False (not True) since Dify datasets don't support deletion via this plugin; add warning log P2: - Replace traceback.print_exc() with logger.exception() - Remove unused RAGEngineCapability import - Remove redundant __kind__ declaration (inherited from RAGEngine) - Remove leading blank line in file - Fix inconsistent indentation in get_creation_settings_schema - Remove unused import (traceback) - Use public package imports instead of internal module paths Co-authored-by: Cursor <cursoragent@cursor.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR migrates the DifyDatasetsRetriever plugin from the deprecated
KnowledgeRetrieverarchitecture to the new unifiedRAGEnginearchitecture introduced in LangBot Core and Plugin SDK.Key Changes
KnowledgeRetrievercomponent withRAGEnginecomponentget_creation_settings_schema()method for dynamic form renderingretrieve,ingest,delete_document)Related
Changes
Added
components/rag_engine/engine.py- New RAGEngine implementationcomponents/rag_engine/dify.yaml- RAGEngine component manifestModified
manifest.yaml- Updated to useRAGEnginecomponent type instead ofKnowledgeRetrieverrequirements.txt- Updatedlangbot-plugin>=0.2.5Deprecated (kept for reference)
components/knowledge_retriever/- Old implementation (can be removed in future)Implementation Details
The new
DifyRAGEngineclass:doc_ingestion) since Dify datasets are managed externallyRetrievalResponseBreaking Changes
KnowledgeRetriever-based configuration is no longer supportedDependencies
langbot-plugin>=0.2.5Checklist