chore(sdk)!: move sandbox provider back to cli #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
github-actions
bot
added
breaking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the SandboxProvider abstraction (and related types/tests) from the deepagents SDK and reintroduces a slimmer sandbox provider interface inside the CLI, reflecting that sandbox lifecycle management is primarily a CLI concern.
Changes:
- Removed
SandboxProvider/metadata/list abstractions and their unit tests from the SDK. - Added a CLI-local
SandboxProviderinterface (sync + async wrappers) and updated CLI integrations to use it. - Updated CLI providers to drop the unused
list()surface and adjusted Runloop provider error handling for missing sandboxes.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libs/deepagents/tests/unit_tests/test_sandbox_provider.py | Removes SDK unit tests tied to SandboxProvider abstractions being deleted. |
| libs/deepagents/deepagents/backends/sandbox.py | Removes SDK SandboxProvider/list/metadata/error types, leaving BaseSandbox focused on backend operations. |
| libs/cli/deepagents_cli/integrations/sandbox_provider.py | Introduces CLI-local sandbox provider interface + async wrappers. |
| libs/cli/deepagents_cli/integrations/sandbox_factory.py | Switches factory typing/imports to the new CLI-local provider interface. |
| libs/cli/deepagents_cli/integrations/runloop.py | Updates provider base class, removes list(), and adds SandboxNotFoundError mapping on retrieve. |
| libs/cli/deepagents_cli/integrations/modal.py | Updates provider base class and removes list() stub. |
| libs/cli/deepagents_cli/integrations/langsmith.py | Updates provider base class and removes list() stub. |
| libs/cli/deepagents_cli/integrations/daytona.py | Updates provider base class and removes list() stub. |
| libs/cli/deepagents_cli/integrations/init.py | Updates module docstring to reflect broader integrations scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove SandboxProvider and related abstractions from the SDK. The SDK doesn't really benefit from it. We'll likely only use it from within the CLI.