-
Notifications
You must be signed in to change notification settings - Fork 45
Brody/port callout install tab changes #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beklapko
wants to merge
7
commits into
main
Choose a base branch
from
brody/port-callout-install-tab-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview ID generated: preview-brodyp-1757358965-579ec3d |
Preview ID generated: preview-brodyp-1757361202-60a1624 |
Preview ID generated: preview-brodyp-1757361421-9918912 |
Related but closed PR just for reference: #381. I created this PR to fix additional stuff but also to start fresh on |
Preview ID generated: preview-brodyp-1757439274-b691185 |
Preview ID generated: preview-brodyp-1757444592-1cee34e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are three main changes in this PR but they're spread across a lot of docs.
For now, I've replaced these with code groups (below is just an example, each code group is different based on the library getting installed)
There is probably a smarter/better long term way to do this with snippets but this was doable in the short term to fix the missing example/broken rendering.
{=mdx}
blocks:So I removed the opening and closing "tags" which fixes the rendering issues.
Unresolved issue
This snippet shows up in several places:
It was enclosed with
{=mdx}
and the triple backticks which caused it to be rendered like this in prod:I removed the enclosing
{=mdx}
so it doesn't get rendered at all, but this doesn't fix the issue entirely. That snippet, from what I can tell, should render out something like this section in the old JS docs: https://js.langchain.com/docs/integrations/retrievers/exa/#use-within-a-chain.It'd take more time and research to see if we can actually recreate that functionality here or not, which this PR does not address.
Testing
I spot checked a few instances of each of these changes locally but I did not verify every change in every file.