Skip to content

Conversation

bvs-langchain
Copy link
Contributor

Overview

Update Okta OIDC configuration section to make it clear it is through Helm/Docker

Type of change

Type: Update existing documentation

Related issues/PRs

  • GitHub issue:
  • Feature PR:
  • Linear issue: part of ent-100
  • Slack thread:

Checklist

  • I have read the contributing guidelines
  • I have tested my changes locally using docs dev
  • All code examples have been tested and work correctly
  • I have used root relative paths for internal links
  • I have updated navigation in src/docs.json if needed
  • I have gotten approval from the relevant reviewers
  • (Internal team members only / optional) I have created a preview deployment using the Create Preview Branch workflow

Additional notes

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 14:45
@github-actions github-actions bot added the langsmith For docs changes to LangSmith label Sep 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Okta OIDC configuration documentation to provide clearer, more practical configuration examples. Instead of describing configuration values in a generic list format, it now provides specific examples for both Helm and Docker deployment methods.

  • Replaces generic configuration description with concrete Helm and Docker examples
  • Adds CodeGroup component to show both deployment methods side-by-side
  • Includes all necessary configuration fields with example values and explanatory comments

Comment on lines +190 to +191
oauthClientId: "Client ID" # (starts with `0o`)
oauthClientSecret: "Client secret"
Copy link
Preview

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example values "Client ID" and "Client secret" are placeholder text that could be confusing. Consider using more obviously placeholder values like <your-client-id> or YOUR_CLIENT_ID_HERE to make it clear these need to be replaced with actual values.

Copilot uses AI. Check for mistakes.

Comment on lines +201 to +202
OAUTH_CLIENT_ID="Client ID" # (starts with `0o`)
OAUTH_CLIENT_SECRET="Client secret"
Copy link
Preview

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as the Helm example - the placeholder values "Client ID" and "Client secret" should use more obvious placeholder formatting to prevent users from literally copying these strings.

Copilot uses AI. Check for mistakes.

Copy link
Contributor

@katmayb katmayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small non-blocking nit, lgtm 👍

Copy link

Preview ID generated: preview-briane-1758898091-8fe4517

Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 01:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copy link

Preview ID generated: preview-briane-1759109150-ea11fc7

Copy link

Preview ID generated: preview-briane-1759109424-f8140c9

@lnhsingh lnhsingh merged commit 9b9badb into main Sep 29, 2025
12 checks passed
@lnhsingh lnhsingh deleted the brian/ent-100-okta-clarify branch September 29, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langsmith For docs changes to LangSmith
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants