-
Notifications
You must be signed in to change notification settings - Fork 31
chore: clarify Okta configuration fields #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Okta OIDC configuration documentation to provide clearer, more practical configuration examples. Instead of describing configuration values in a generic list format, it now provides specific examples for both Helm and Docker deployment methods.
- Replaces generic configuration description with concrete Helm and Docker examples
- Adds CodeGroup component to show both deployment methods side-by-side
- Includes all necessary configuration fields with example values and explanatory comments
oauthClientId: "Client ID" # (starts with `0o`) | ||
oauthClientSecret: "Client secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example values "Client ID" and "Client secret" are placeholder text that could be confusing. Consider using more obviously placeholder values like <your-client-id>
or YOUR_CLIENT_ID_HERE
to make it clear these need to be replaced with actual values.
Copilot uses AI. Check for mistakes.
OAUTH_CLIENT_ID="Client ID" # (starts with `0o`) | ||
OAUTH_CLIENT_SECRET="Client secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as the Helm example - the placeholder values "Client ID" and "Client secret" should use more obvious placeholder formatting to prevent users from literally copying these strings.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small non-blocking nit, lgtm 👍
Preview ID generated: preview-briane-1758898091-8fe4517 |
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Preview ID generated: preview-briane-1759109150-ea11fc7 |
Preview ID generated: preview-briane-1759109424-f8140c9 |
Overview
Update Okta OIDC configuration section to make it clear it is through Helm/Docker
Type of change
Type: Update existing documentation
Related issues/PRs
Checklist
docs dev
src/docs.json
if neededAdditional notes