Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make job name randomization optional #186

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/langsmith/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ maintainers:
email: ankush@langchain.dev
description: Helm chart to deploy the langsmith application and all services it depends on.
type: application
version: 0.8.13
version: 0.8.14
appVersion: "0.8.38"
5 changes: 4 additions & 1 deletion charts/langsmith/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# langsmith

![Version: 0.8.13](https://img.shields.io/badge/Version-0.8.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.8.38](https://img.shields.io/badge/AppVersion-0.8.38-informational?style=flat-square)
![Version: 0.8.14](https://img.shields.io/badge/Version-0.8.14-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.8.38](https://img.shields.io/badge/AppVersion-0.8.38-informational?style=flat-square)

Helm chart to deploy the langsmith application and all services it depends on.

Expand Down Expand Up @@ -225,6 +225,7 @@ For information on how to use this chart, up-to-date release notes, and other gu
| backend.authBootstrap.labels | object | `{}` | |
| backend.authBootstrap.nodeSelector | object | `{}` | |
| backend.authBootstrap.podSecurityContext | object | `{}` | |
| backend.authBootstrap.randomizeName | bool | `true` | |
| backend.authBootstrap.resources | object | `{}` | |
| backend.authBootstrap.securityContext | object | `{}` | |
| backend.authBootstrap.sidecars | list | `[]` | |
Expand All @@ -249,6 +250,7 @@ For information on how to use this chart, up-to-date release notes, and other gu
| backend.clickhouseMigrations.labels | object | `{}` | |
| backend.clickhouseMigrations.nodeSelector | object | `{}` | |
| backend.clickhouseMigrations.podSecurityContext | object | `{}` | |
| backend.clickhouseMigrations.randomizeName | bool | `true` | |
| backend.clickhouseMigrations.resources | object | `{}` | |
| backend.clickhouseMigrations.securityContext | object | `{}` | |
| backend.clickhouseMigrations.sidecars | list | `[]` | |
Expand Down Expand Up @@ -317,6 +319,7 @@ For information on how to use this chart, up-to-date release notes, and other gu
| backend.migrations.labels | object | `{}` | |
| backend.migrations.nodeSelector | object | `{}` | |
| backend.migrations.podSecurityContext | object | `{}` | |
| backend.migrations.randomizeName | bool | `true` | |
| backend.migrations.resources | object | `{}` | |
| backend.migrations.securityContext | object | `{}` | |
| backend.migrations.sidecars | list | `[]` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/langsmith/templates/backend/auth-bootstrap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
apiVersion: batch/v1
kind: Job
metadata:
name: {{ include "langsmith.fullname" . }}-{{ .Values.backend.name }}-auth-bootstrap-{{ randAlphaNum 5 | lower}}
name: {{ include "langsmith.fullname" . }}-{{ .Values.backend.name }}-auth-bootstrap{{ ternary (printf "-%s" (randAlphaNum 5 | lower)) "" .Values.backend.authBootstrap.randomizeName }}
labels:
{{- include "langsmith.labels" . | nindent 4 }}
{{- with.Values.backend.authBootstrap.labels }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: batch/v1
kind: Job
metadata:
name: {{ include "langsmith.fullname" . }}-{{ .Values.backend.name }}-ch-migrations-{{ randAlphaNum 5 | lower}}
name: {{ include "langsmith.fullname" . }}-{{ .Values.backend.name }}-ch-migrations{{ ternary (printf "-%s" (randAlphaNum 5 | lower)) "" .Values.backend.clickhouseMigrations.randomizeName }}
labels:
{{- include "langsmith.labels" . | nindent 4 }}
{{- with.Values.backend.clickhouseMigrations.labels }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: batch/v1
kind: Job
metadata:
name: {{ include "langsmith.fullname" . }}-{{ .Values.backend.name }}-pg-migrations-{{ randAlphaNum 5 | lower}}
name: {{ include "langsmith.fullname" . }}-{{ .Values.backend.name }}-migrations{{ ternary (printf "-%s" (randAlphaNum 5 | lower)) "" .Values.backend.migrations.randomizeName }}
labels:
{{- include "langsmith.labels" . | nindent 4 }}
{{- with.Values.backend.migrations.labels }}
Expand Down
6 changes: 6 additions & 0 deletions charts/langsmith/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,8 @@ backend:
volumeMounts: []
migrations:
enabled: true
# Helpful when running using helm template to avoid the job name conflict
randomizeName: true
labels: {}
annotations: {}
podSecurityContext: {}
Expand Down Expand Up @@ -308,6 +310,8 @@ backend:
# You can set this to null to disable the TTL for the migrations job. Useful for some deployment setups.
ttlSecondsAfterFinished: 600
authBootstrap:
# Helpful when running using helm template to avoid the job name conflict
randomizeName: true
labels: {}
annotations: {}
podSecurityContext: {}
Expand Down Expand Up @@ -335,6 +339,8 @@ backend:
ttlSecondsAfterFinished: 600
clickhouseMigrations:
enabled: true
# Helpful when running using helm template to avoid the job name conflict
randomizeName: true
labels: {}
annotations: {}
podSecurityContext: {}
Expand Down