-
Notifications
You must be signed in to change notification settings - Fork 35
feat: add rank_fields to rerank v3 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! We'll need to update the minimum SDK version to 5.2.5, which is blocked currently. We'll work on resolving this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above - I'll get back to you!
* fix nits and small bugs * nits * nits * update func tool name * update tests
* fix nits and small bugs * nits * nits * update func tool name * update tests
This seems to have broken compatibility with the # HACK: Override the `rerank` method to remove any unsupported parameters in this version of LangChain.
cohere.BedrockClientV2.rerank = (lambda original:
lambda self, *args, **kwargs: original(
self, *args,
**{k: v for k, v in kwargs.items() if
k in inspect.signature(original).parameters}
)
)(cohere.BedrockClientV2.rerank)
|
No description provided.