community: add scope validation for Google Drive API credentials #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhukar32
force-pushed
the
drive-creds-scope
branch
from
f7ba9c7 to
73da557
Compare
|
Hi @lkuligin, Could you pls review the PR when you get a chance? Thanks |
lkuligin
approved these changes
Jan 4, 2025
|
@madhukar32 Thanks for your contribution! Please, take a look at remaining linter errors, and I'm happy to merge when it's fixed. |
…ials Add validation for Google Drive API scopes to ensure only valid scopes are provided. This improves error handling by validating scopes before attempting to use them with the API, providing clearer error messages when invalid scopes are specified. ref: langchain-ai#666
madhukar32
force-pushed
the
drive-creds-scope
branch
from
73da557 to
ec6ffbf
Compare
Thanks @lkuligin for your response, I fixed the lint errors and pushed it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR makes the Google Drive API scopes configurable in the GoogleDriveLoader class instead of using a hardcoded global constant. This change allows users to specify different scopes based on their needs while maintaining backward compatibility with the default
drive.filescope.Currently, the scope is hardcoded to
drive.filewhich is restrictive and only allows access to files created by the app. This change enables users to use different scopes likedrive.readonlyfor broader read access without modifying the source code.Relevant issues
ref: #666
Type
🐛 Bug Fix
Changes(optional)
scopesparameter toGoogleDriveLoaderclass