anthropic on vertexai: Update parsed parameter from image_url to image
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the type image input from `image_url` to `image` for compliance with the anthropic latest api
lkuligin
approved these changes
Jan 4, 2025
|
Does this change applies to all Anthropic models? In other words, is this change backwards compatible to old models that users might still be using? |
@lkuligin yes, the new format is also specified in Model Garden for all claude models including 3 Opus and 3 Sonnet (haiku does not do multimodel anw) |
|
@dotrunghieu96 it looks like some unit tests require an update after your change. Could you take a look, please? |
dotrunghieu96
changed the title
|
@lkuligin I haved updated the unittest case, please check again :D Thanks. |
dotrunghieu96
changed the title
image_url to image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the type image input from
image_urltoimagefor compliance with the anthropic latest apiPR Description
Update the type
image_urltoimagewhen sending request to vertex anthropic api for compliance with the latest anthropic api formatRelevant issues
Fixes #668
Type
🐛 Bug Fix
Changes(optional)
Testing(optional)
Note(optional)