vertexai: Add ChatAnthropicVertex Text Caching Support #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuligin
reviewed
Jan 6, 2025
| content: List[Dict[str, Any]] = [] | ||
|
|
||
| if isinstance(message.content, str): | ||
| if not message.content.strip(): | ||
| return None | ||
| content.append({"type": "text", "text": message.content}) | ||
| content.append( | ||
| _format_text_content(message.content, _get_cache_control(message)) |
There was a problem hiding this comment.
nits: maybe it would be more readable if _format_text_content expects a message only, and handles cache control itself, wdyt?
There was a problem hiding this comment.
@lkuligin
Hey, thank you all for the review!
That’s a good observation.
To avoid duplicating logic and keep the code more readable, I keep the code in the same if statement.
lkuligin
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for cache control in VertexAI ChatAnthropic text messages.
Relevant issues
#651
Type
🆕 New Feature
🧹 Refactoring
✅ Test
Changes
CacheUsageMetadataclass extendingUsageMetadatato track cache-specific token usageTesting