genai: fix function_utils to parse object/array json schemas properly #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the change, please, fix linting errors. I'm not sure it's a bug, we probably have it intentianally since old models didn't support |
RazCrimson
force-pushed
the
main
branch
2 times, most recently
from
1cb6710 to
e1b291c
Compare
- An `items` field in JSON Schema can't have `items` as its direct child
|
@lkuligin Fixed lint errors PTAL |
lkuligin
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code tries to handle arrays and objects in anyOf fields of JSON Schema's for tools by picking the last possible non nullable choice in anyOf. But the context of the field is not updated to reflect the selected choice leading to a borked conversion to protobuf that fails with 400 errors.
This fix is just to update the context for arrays and objects.
Please correct me if it is intentional, but there is already a testcase which is supposed to cover this, but it is buggy as it sets an
itemsfield within anitemsdefinition for an array, which should not be possible according to the JSON Schema spec. The faulty setting made this bug slip through the tests