Skip to content

partners[chroma]: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI #28345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

lucasile
Copy link

@lucasile lucasile commented Nov 26, 2024

image
^ New Integration Tests for Chroma server using Async api (posted ss since you need to run a local chroma server for these to run)

Addressing #27225

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message:

    • Description: Allow Chroma Vectorstore to accept AsyncClientAPI alongside ClientAPI and implement asynchronous functions to use it.
    • Dependencies: no new - chromadb
  • Add tests and docs:

  1. Added integration tests for new async functionality

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:50pm

@lucasile lucasile changed the title **Add Async Functionality to ChromaDB**: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI **Add Async Functionality to ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" Nov 26, 2024
@lucasile lucasile changed the title **Add Async Functionality to ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" **Async ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" Nov 26, 2024
@lucasile lucasile closed this Nov 26, 2024
@lucasile lucasile reopened this Nov 26, 2024
@lucasile lucasile closed this Nov 26, 2024
@lucasile lucasile reopened this Nov 26, 2024
@lucasile lucasile closed this Nov 26, 2024
@lucasile lucasile reopened this Nov 26, 2024
@lucasile lucasile marked this pull request as ready for review November 26, 2024 05:57
@lucasile lucasile changed the title **Async ChromaDB**: "partners: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI" partners[chroma]: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI Nov 26, 2024
@dosubot dosubot bot added size:M and removed size:XXL labels Nov 27, 2024
@dosubot dosubot bot added size:XXL and removed size:M labels Nov 27, 2024
@efriis
Copy link
Contributor

efriis commented Dec 9, 2024

tried merging in master briefly - I may have done something wrong. A lot of integration tests fail after this PR. Could you take a look?

@efriis efriis self-assigned this Dec 9, 2024
@efriis
Copy link
Contributor

efriis commented Dec 17, 2024

closing and feel free to reopen when you have a chance to look!

You'll have to get CI passing for this to be mergeable. Here's how you can run it locally:

First, install poetry, e.g. with curl -sSL https://install.python-poetry.org | python3 - on non-windows machines (see link for other ways of installing)

Then, for example if you're in community, you can run

# enter package you're checking, e.g. community:
cd libs/community

# format and lint
poetry install --with lint,typing --sync
make format lint

# test
poetry install --with lint,typing,test --sync
make test

# extended tests - install extra deps with uv - not a requirement but it's how I do it
poetry install --with lint,typing,test --sync
poetry run pip install uv
poetry run uv pip install -r extended_testing_deps.txt
make extended_tests

# integration tests
poetry install --with lint,typing,test,test_integration --sync
make integration_tests

# run a specific test - helpful if trying to just fix a single test
poetry run pytest --disable-socket --allow-unix-socket tests/unit_tests -k test_my_test_name

@efriis efriis closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants