-
Notifications
You must be signed in to change notification settings - Fork 18.3k
partners[chroma]: Add Async Functionality to ChromaDB Vectorstore using AsyncClientAPI #28345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
9a89313
to
b3d521b
Compare
b3d521b
to
9a89313
Compare
tried merging in master briefly - I may have done something wrong. A lot of integration tests fail after this PR. Could you take a look? |
closing and feel free to reopen when you have a chance to look! You'll have to get CI passing for this to be mergeable. Here's how you can run it locally: First, install poetry, e.g. with Then, for example if you're in community, you can run # enter package you're checking, e.g. community:
cd libs/community
# format and lint
poetry install --with lint,typing --sync
make format lint
# test
poetry install --with lint,typing,test --sync
make test
# extended tests - install extra deps with uv - not a requirement but it's how I do it
poetry install --with lint,typing,test --sync
poetry run pip install uv
poetry run uv pip install -r extended_testing_deps.txt
make extended_tests
# integration tests
poetry install --with lint,typing,test,test_integration --sync
make integration_tests
# run a specific test - helpful if trying to just fix a single test
poetry run pytest --disable-socket --allow-unix-socket tests/unit_tests -k test_my_test_name |
^ New Integration Tests for Chroma server using Async api (posted ss since you need to run a local chroma server for these to run)
Addressing #27225
PR title: "package: description"
PR message:
Add tests and docs:
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.