Skip to content

openai[patch]: accommodate change in image generation API #31522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Jun 6, 2025

OpenAI changed their API to require the partial_images parameter when using image generation + streaming.

As described in #31424, we are ignoring partial images. Here, we accept the partial_images parameter (as required by OpenAI), but emit a warning and continue to ignore partial images.

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 9, 2025 5:58pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 6, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 6, 2025
Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Walltime Performance Report

Merging #31522 will not alter performance

Comparing cc/oai_fix_streaming_images (fe6416e) with master (ece9e31)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Instrumentation Performance Report

Merging #31522 will not alter performance

Comparing cc/oai_fix_streaming_images (fe6416e) with master (ece9e31)

Summary

✅ 13 untouched benchmarks

@ccurme ccurme changed the title openai[patch]: allow partial image parameter openai[patch]: accommodate change in image generation API Jun 9, 2025
@ccurme ccurme merged commit 575662d into master Jun 9, 2025
57 checks passed
@ccurme ccurme deleted the cc/oai_fix_streaming_images branch June 9, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants