Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(py): Rename CLI arg for pytest plugin from --output to --langsmith-output to avoid conflict #1472

Closed
wants to merge 9 commits into from
Closed

fix(py): Rename CLI arg for pytest plugin from --output to --langsmith-output to avoid conflict #1472

wants to merge 9 commits into from

Conversation

rkechols
Copy link
Contributor

@rkechols rkechols commented Jan 29, 2025 •
edited
Loading

Description

Including the pytest plugin in the base package and having it enabled by default creates conflicts with other pytest plugins (see issue #1469).

This PR:

  • Renames the command-line argument for pytest plugin from --output to --langsmith-output
  • Updates in-repo documentation regarding the pytest plugin

TODO

@rkechols rkechols mentioned this pull request Jan 29, 2025
Closed
@jacoblee93 jacoblee93 requested a review from baskaryan January 29, 2025 21:02
@rkechols
Copy link
Contributor Author

@jacoblee93 I've just tested locally, and renaming to --langsmith-output does indeed resolve the conflict

@jacoblee93
Copy link
Collaborator

Awesome, thanks! Just going to get a test case or two and will be good to ship :)

Thanks @rkechols

@rkechols rkechols changed the title Require opt-in for pytest plugin Rename CLI arg for pytest plugin from --output to --langsmith-output Jan 31, 2025
baskaryan
baskaryan reviewed Jan 31, 2025
View reviewed changes
python/README.md Outdated Show resolved Hide resolved
@jacoblee93
Copy link
Collaborator

Integration test failure seems unrelated @baskaryan

@jacoblee93 jacoblee93 requested a review from baskaryan January 31, 2025 17:51
@jacoblee93 jacoblee93 changed the title Rename CLI arg for pytest plugin from --output to --langsmith-output Rename CLI arg for pytest plugin from --output to --langsmith-output to avoid conflict Jan 31, 2025
@jacoblee93 jacoblee93 mentioned this pull request Jan 31, 2025
Merged
@rkechols
Copy link
Contributor Author

Looks good to me!
Thanks for your responsiveness and cooperation!

@baskaryan baskaryan enabled auto-merge (squash) January 31, 2025 18:37
@baskaryan baskaryan disabled auto-merge January 31, 2025 18:37
@baskaryan baskaryan enabled auto-merge (squash) January 31, 2025 18:38
@jacoblee93 jacoblee93 changed the title Rename CLI arg for pytest plugin from --output to --langsmith-output to avoid conflict fix(py): Rename CLI arg for pytest plugin from --output to --langsmith-output to avoid conflict Jan 31, 2025
@jacoblee93 jacoblee93 mentioned this pull request Jan 31, 2025
Merged
@jacoblee93
Copy link
Collaborator

Closing this in favor of #1482 in order to get this out

jacoblee93 added a commit that referenced this pull request Jan 31, 2025
@jacoblee93 @rkechols
fix(py): Rename CLI arg for pytest plugin from --output to --langsmit…
130f87d 
…h-output to avoid conflict (#1482)

Copy of #1472, since something is wrong with our secrets injection for
contributors in CI

---------

Co-authored-by: Ryan Echols <rechols@qualiti.ai>
Co-authored-by: Ryan Echols <rkechols21@gmail.com>
@rkechols rkechols closed this Jan 31, 2025
auto-merge was automatically disabled January 31, 2025 20:30

Pull request was closed

@rkechols rkechols deleted the py/rke/pytest-plugin branch January 31, 2025 21:30
jacoblee93 added a commit to langchain-ai/langsmith-docs that referenced this pull request Feb 1, 2025
@jacoblee93
docs: Update pytest table output (#656)
f08a087 
Reflect langchain-ai/langsmith-sdk#1472

Merge after release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 left review comments

@baskaryan baskaryan Awaiting requested review from baskaryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkechols @jacoblee93 @baskaryan