Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug log the serialization issues #1495

Merged
merged 2 commits into from
Feb 9, 2025
+2 −2
Merged

Debug log the serialization issues #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c67e119
Debug log the serialization issues
hinthornw Feb 6, 2025
a9ef70d
Merge branch 'main' into wfh/debug
hinthornw Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/langsmith/_internal/_serde.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from __future__ import annotations

Check notice on line 1 in python/langsmith/_internal/_serde.py

View workflow job for this annotation

GitHub Actions / benchmark

Benchmark results 

...........
create_5_000_run_trees: Mean +- std dev: 667 ms +- 49 ms
...........
create_10_000_run_trees: Mean +- std dev: 1.34 sec +- 0.11 sec
...........
create_20_000_run_trees: Mean +- std dev: 2.65 sec +- 0.14 sec
...........
dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 712 us +- 21 us
...........
dumps_class_nested_py_leaf_50x100: Mean +- std dev: 24.8 ms +- 0.3 ms
...........
dumps_class_nested_py_leaf_100x200: Mean +- std dev: 105 ms +- 3 ms
...........
dumps_dataclass_nested_50x100: Mean +- std dev: 25.1 ms +- 0.1 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (8.17 ms) is 14% of the mean (56.8 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

dumps_pydantic_nested_50x100: Mean +- std dev: 56.8 ms +- 8.2 ms
...........
dumps_pydanticv1_nested_50x100: Mean +- std dev: 195 ms +- 2 ms

Check notice on line 1 in python/langsmith/_internal/_serde.py

View workflow job for this annotation

GitHub Actions / benchmark

Comparison against main 

+-----------------------------------------------+----------+------------------------+
| Benchmark                                     | main     | changes                |
+===============================================+==========+========================+
| dumps_pydantic_nested_50x100                  | 66.3 ms  | 56.8 ms: 1.17x faster  |
+-----------------------------------------------+----------+------------------------+
| dumps_pydanticv1_nested_50x100                | 218 ms   | 195 ms: 1.12x faster   |
+-----------------------------------------------+----------+------------------------+
| create_20_000_run_trees                       | 2.71 sec | 2.65 sec: 1.02x faster |
+-----------------------------------------------+----------+------------------------+
| create_5_000_run_trees                        | 678 ms   | 667 ms: 1.02x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_dataclass_nested_50x100                 | 25.2 ms  | 25.1 ms: 1.00x faster  |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_50x100             | 24.9 ms  | 24.8 ms: 1.00x faster  |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_branch_and_leaf_200x400 | 709 us   | 712 us: 1.00x slower   |
+-----------------------------------------------+----------+------------------------+
| create_10_000_run_trees                       | 1.32 sec | 1.34 sec: 1.01x slower |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_100x200            | 103 ms   | 105 ms: 1.02x slower   |
+-----------------------------------------------+----------+------------------------+
| Geometric mean                                | (ref)    | 1.03x faster           |
+-----------------------------------------------+----------+------------------------+

import base64
import collections
Expand Down Expand Up @@ -105,7 +105,7 @@
return str(response)
return response
except Exception as e:
logger.error(
logger.debug(
f"Failed to use {attr} to serialize {type(obj)} to"
f" JSON: {repr(e)}"
)
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "langsmith"
version = "0.3.7"
version = "0.3.8"
description = "Client library to connect to the LangSmith LLM Tracing and Evaluation Platform."
authors = ["LangChain <support@langchain.dev>"]
license = "MIT"
Expand Down