feat: add support for cycles in graph #3295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement functions to check for cycles in a directed graph and find cycle edges starting from a specific vertex. Also, include a function to find all edge cycles in a directed graph.
…handle cyclic graphs.
…s instead of lists.
- Added flow_id variable to store the graph's flow_id - Improved error handling and logging in build method - Added conditional log_transaction calls based on flow_id - Handled cases for normal and contract edges in build method - Avoided unnecessary log_vertex_build import
dosubot
bot
added
size:XL
…on in the component class.
… for component output.
…efinder to pyproject.toml.
Detected 1 changes to dependencies in Poetry lockfileAdded pytest-flakefinder (1.1.0) (1 added, 0 removed, 0 updated, 477 not changed) |
dosubot
bot
added
size:XXL
ogabrielluiz
force-pushed
the
feat-add-support-for-cycles-in-graph
branch
from
8e73965 to
ff78520
Compare
ogabrielluiz
force-pushed
the
feat-add-support-for-cycles-in-graph
branch
from
49e7f00 to
bffac9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for cyclic graphs by setting a start component and postponing a dependency resolution if it is part of a cyclic edge.
It implements logic to instantiate two different types of edges: Edge and CycleEdge, and updates many ordering functions to make sure they have a stop condition.