fix: Improve waiting logic in playground.spec.ts #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
ogabrielluiz
requested changes
Nov 18, 2024
Comment on lines
+284
to
+285
| await page.waitForSelector('text="New chat"', { | ||
| timeout: 5000, |
There was a problem hiding this comment.
Why did you remove the rest of this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the waiting logic in the
playground.spec.tsfile. It replaces the use ofpage.waitForTimeoutwithpage.waitForSelectorto wait for specific elements to appear on the page. This change ensures more reliable and efficient waiting in the test cases.