feat: Add database cleanup functions for transactions and vertex builds #4694
+87
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atabase - Implement `clean_transactions` to delete transactions exceeding the configured limit. - Implement `clean_vertex_builds` to delete vertex builds exceeding the configured limit. - Integrate cleanup functions into the service initialization process.
dosubot
bot
added
size:M
github-actions
bot
added
enhancement
- Wrap transaction and vertex build cleanup operations in try-except blocks. - Log success and error messages for cleanup operations. - Rollback session on exceptions without re-raising, as these are cleanup tasks. - Adjust service initialization order to ensure proper setup.
CodSpeed Performance ReportMerging #4694 will degrade performances by 36.25%Comparing Summary
Benchmarks breakdown
|
cbornet
reviewed
Nov 19, 2024
| async def initialize_services(*, fix_migration: bool = False) -> None: | ||
| """Initialize all the services needed.""" | ||
| # Test cache connection | ||
| get_service(ServiceType.CACHE_SERVICE, default=CacheServiceFactory()) | ||
| # Setup the superuser | ||
| await asyncio.to_thread(initialize_database, fix_migration=fix_migration) | ||
| async with get_db_service().with_async_session() as session: | ||
| await setup_superuser(get_service(ServiceType.SETTINGS_SERVICE), session) | ||
| settings_service = get_service(ServiceType.SETTINGS_SERVICE) |
There was a problem hiding this comment.
Alignment of the try block seems incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functions to clean up old transactions and vertex builds in the database, ensuring that only a configured maximum number of each is retained. The
clean_transactionsfunction deletes transactions exceeding the specified limit, whileclean_vertex_buildsperforms a similar cleanup for vertex builds. Additionally, these cleanup functions are integrated into the service initialization process, and new configuration options for maximum retention limits have been added.