Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Components cleanup #5987

Merged
merged 26 commits into from
Jan 31, 2025
Merged

Docs: Components cleanup #5987

merged 26 commits into from
Jan 31, 2025

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Jan 28, 2025

This pull request includes several updates and additions to documentation across various components. The most significant changes involve renaming components, deprecating older components, and adding new components with detailed descriptions and usage instructions.

Documentation Updates:

  • docs/docs/Agents/agent-tool-calling-agent-component.md: Updated the documentation to replace references to the "Flow as Tool" component with the "Run Flow" component.

  • docs/docs/Components/components-data.md:

    • Enhanced the API Request component to support cURL commands and added new input fields.
    • Reintroduced the URL component with updated inputs and outputs.
    • Specified a maximum supported file size for the FileComponent.

Component Deprecations:

New Component Additions:

@mendonk mendonk self-assigned this Jan 28, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 28, 2025
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 30, 2025
Copy link
Collaborator

@KimberlyFields KimberlyFields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mendonk I'm approving this PR so the new content can be published. However, you need to create a Jira ticket to go through all of the component content and audit it for style consistency and clarify. I see a lot of inconsistencies in punctuation, capitalization, and usage of articles. Also, there's a lot of "duh" doc in here, meaning that the description of an input or output repeats the name of the input/output with not additional explanation. Where you can, you need to add context around the input and output items.

@mendonk mendonk enabled auto-merge January 31, 2025 19:20
@mendonk mendonk added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 31c6b12 Jan 31, 2025
10 checks passed
@mendonk mendonk deleted the docs-vector-stores-opensearch branch January 31, 2025 20:36
edwinjosechittilappilly pushed a commit that referenced this pull request Jan 31, 2025
* docs: Expand vector stores documentation with new components

Add detailed documentation for:
- AstraDB Graph vector store
- Elasticsearch vector store

Update existing documentation links and improve component descriptions

* filesize-note

* docs: Update memory chatbot tutorial and add new components documentation

* docs: new-api-request-inputs

* docs: Update documentation to replace deprecated "Flow as Tool" with "Run flow" component

* docs: Add Tavily AI Search and Wikidata components documentation

* renamed-conditional-router

* move-url-component

* docs:url-fix

* Apply suggestions from code review

* docs: cloudflare links

* docs: improve link formatting

* docs: add output details

* docs: add SQL Query and Batch Run component

* fix-bottom-table

* avoid-future-tense

* code-review

* Apply suggestions from code review

Co-authored-by: KimberlyFields <46325568+KimberlyFields@users.noreply.github.com>

* fix-linking-errors

---------

Co-authored-by: KimberlyFields <46325568+KimberlyFields@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants